[17.0][MIG] account_chart_update #1888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX]: Changed types to orm.Model, orm.TransientModel and orm.AbstractModel. [FIX]: Fix deletion method for some fields of objects. [FIX]: Contributions have been written in the standard format of the community. [FIX]: Changes in the form to work as a real wizard. [FIX]: Remove 'init_xml' keys, because it's no longer needed in v7. [FIX]: Rename 'demo_xml' key to the new standard 'demo'. [FIX]: Change imports calls. [FIX]: Remove __author__ variables in files, because authors are put on manifest file (__openerp__.py). [FIX]: Update view definitions to version 7.0 [FIX]: Rename variables to OpenERP standard. [FIX]: Increased compatibility with standard PEP8. [IMP]: User Invitu add the method call _reopen to keep open the wizard. [MRG]: User Invitu add frech language.
…ing. [FIX] account_chart_update: Adapted to work with inherited account chart templates. [FIX] account_chart_update: Remove required=True for chart_template_id on DB and put on screen to avoid error when removing chart templates. [FIX] account_chart_update: Change method to compare taxes of fiscal positions to match with the one comparing taxes. [FIX] account_chart_update: Change method to compare accounts of fiscal positions to match with the one comparing accounts. [IMP] account_chart_update: Wizard now shows in tree view modification notes. [IMP] account_chart_update: For new data to be created, it is marked on notes the reason for the creation (just for clarity). [IMP] account_chart_update: Tabs for operations that are not going to be performed are hidden. [IMP] account_chart_update: Some PEP8 here and there. [IMP] account_chart_update: Enhance a little the mapping searches (there's more room to improve). [IMP] account_chart_update: Now it takes into account name and description for mapping taxes.
* Move out of unported * Set account_chart_update installable * value_reference of ir.property is a char * Use get_by_record method of ir.property * number digits is returned before assignment in case of property exist but account not * product_obj isn't used
* search on code first to match tax codes The tax code code should be more discriminant that the tax code name. * compare more fields in tax codes * deletion of tax codes removed from templates For tax codes, it make sense to propose deletion, since tax codes are normally defined by the tax authority and the user does not customize them. * update accounts on taxes even if an update of the account was not requested Useful when the chart of taxes changes but the chart of account need not be updated. * depth-first search of tax codes This helps creating parents before children. * compare more fields in taxes * add active field on tax code Deactivate tax codes which are not in the template. * deactivate taxes that are not in the template * multi-company criteria for taxes * avoid inserting duplicates in presence of inactive taxes or tax codes
* Fix calculated field when showing inactives + add field to view * Migrated to new API. * Provided hooks for detecting changes and for adding update/create values. * Purge dead error detection code (not applying). * Use global mapping dictionaries stored on class instead of passing arguments down to top and viceversa. * Number fields computed by a function field instead of being computed by hand. * Use recordsets as indexes instead of ids to avoid repetitive browses. * Re-enable local cache variables * README + authors
* Set updated taxes as active * Check parent_id field in '_is_different_tax' method * PEP8 * Spanish translation
As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.
* Process price_include field * Detect change in price_include field
- New-style license headers. - Remove .pot file. - Remove tax codes stuff, now removed from v9. - Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive. - Only update fields that have any kind of change on any updated record. - Place the wizard in the configuration page, instead of its own menu item. - Display amount of disabled taxes at ending page.
…tions + clean authors As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.
When marking methods as ormcache, you can't return recordsets, as they keep the cursor information, and that cursor can be closed (worker spawn for example) when you need to access again data. This is fixed returning IDs instead, and browsing when needed
* Compare all fields from template Not all fields were properly compared with previous code. This means also to exclude some of them, but now we have a full and extensible system. * Optimize cached method * Generate accounts and fiscal positions using Odoo methods (tax already did) * README by fragments * Add tests up to full coverage
In v10, tax templates have an active flag. It is useful to copy them too, letting the user select which one he wants to activate in it's instance.
With this option, you can select which fields do you want to compare for updating. Use case: you have specific accounts in taxes, and you don't want to lose them, but you want to update their groups through the wizard. Before this, the update was all or nothing. Now, you have total control!
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
For improving performance.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/
… a recordset todo_dict["account_dict"]["account.tax"].keys() are already records, not just ID, so we can use them directly. Trying to browse causes an error : `psycopg2.ProgrammingError: can't adapt type 'account.tax'`.
…ansactionCase - Depending on l10n_generic_coa is the lazy option for not putting proper initialization data on the test, and it also couples the tests to the external module changes. - Switch to TransactionCase, for populating once the company, CoA, etc. - Speed up a bit the tests, removing superflual mail operations.
Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/es/
Use tax record as key in tax_template_ref dict because in odoo/account/models/chart_template.py line 959, the given key on dict reading is a tax record and not a simple id.
Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/es_AR/
Currently translated at 94.1% (129 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/pt_BR/
Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/sv/
Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/pt_BR/
|
@dreispt error installing module in runboat |
|
I assume this PR will be stale note it has to be adapted for |
|
Are you taking into account this refactor? odoo/odoo#110016 |
Not in this PR. The error it raises as told by @ioans73 on installation time is basically due to that. |
|
Yes, this needs significant changes to work, since there were big changes upstream. @pedrocs-exo you mentioned to me you were planning to work on this, is it still the case? |
|
Is anyone working on this RM? If not, I will migrate the module to 17. Any help is welcome. Thanks |
|
Just make sure it's needed. Odoo uses a completely new system for CoA templates in v17, and they already have methods for loading it AFAIK. So possibly this module is no longer needed or, if needed, it can be much slimmer. |
8 tasks
|
Superseded by #1989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.