-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] account_tax_round_down #2005
base: 16.0
Are you sure you want to change the base?
Conversation
eff818b
to
6510acb
Compare
There seems to be a happy-new-year error in a test from account_fiscal_year_auto_create, which I think will be cleared if I push again tomorrow.
This line seems to be an issue: https://github.com/OCA/account-financial-tools/blob/2ae3d17/account_fiscal_year_auto_create/models/account_fiscal_year.py#L24 CC: @legalsylvain |
6510acb
to
bc6afb1
Compare
I was wondering if there is any real need in the community outside Japan for rounding down calculated tax amounts. If not, I might just include this module in the l10n-japan repo instead. Your comments are welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code check and functional review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: LGTM
This PR has the |
This module provides the function of rounding down the tax amount in invoices (and also
other business documents such as sales orders and purchase orders).
By default, Odoo uses the "HALF-UP" method to round tax amounts. However, in some
regions, such as Japan, some industries have a common practice of rounding down instead.
This module accommodates such local conventions by offering an alternate rounding method.
@qrtl QT4986