[MIG] account_move_name_sequence: Migration to 18.0 #2016

CLaurelB · 2025-01-20T18:42:41Z

Supersed: #1954

This module restores the good old behavior where journal entry numbers were generated from a sequence configured on the journal.

Add post-install script to create a sequence for all existing journals Update README accordingly

…ge lines data based on current moves

…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged

…if it is empty

After remove required=True for journal.sequence_id field it is possible to post an invoice with misconfigured journal with empty sequence So, this constraint will raise an error for this kind of cases since that using '/' could raise the unique constraint for all other moves

The required flag was wrong for sequence_id and refund_sequence_id So, it was not possible to store any change in journal for journal different to sale and purchase

…nd_of_seq_chain

…efix In case you want name your invoice YYYY-MM-SEQ (ie: 2022-07-00001) where: * YYYY: is the account move year * MM: is the account move month * SEQ: is a numerical sequence that is continue along the fiscal year assuming fiscal year is over two years (ie: from july to june next year) Before this commit the sequence prefix use now() to be compute but the range is selected with the account move date. This commit make consistency computing prefix with the account move date as well. So account move manage the first janunary for the last day of the previous year will properly use the account move date. Co-authored-by: Alexis de Lattre <[email protected]>

…space between name and returns.

…ence true if value not get in vals

…supplier_reference method same issue OCA#1501 this fix not working for v16 OCA#1514

…rom the readme

…e" module the "_get_last_sequence" method does not have to propagate the with_prefix parameter. The sequence_prefix parameter will not be completed and will give error as it is False in this line of code. https://github.com/OCA/OCB/blob/16.0/addons/account/models/sequence_mixin.py#L169

…eck sequence fix: odoo/odoo@6112f4f

Currently translated at 100.0% (20 of 20 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_name_sequence/fr/

Rename hooks file and use post_init_hook method to create journal sequences after module installation.

…the name The core compute function for the name is calling at the end the function self._inverse_name(), which updates the payment_reference when required. This code was currently missing, causing the payment_reference not being properly computed, for example, when using QR-Bills.

…invoices Add demo data with standard implementation sequences In order to test locks issues without changing data (then reverting)

Split the context definition in sequence_id and refund_sequence_id fields into multiple lines to improve readability.

Update name of view files to follow guidelines.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/

Currently translated at 100.0% (22 of 22 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/it/

Currently translated at 100.0% (22 of 22 strings) Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_move_name_sequence Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_move_name_sequence/es/

CLaurelB · 2025-01-21T09:13:47Z

@luisg123v could you review, please?

thienvh332

Just nitpicking 😉

thienvh332 · 2025-01-22T03:14:53Z

account_move_name_sequence/models/account_journal.py

+                and journal.refund_sequence_id == journal.sequence_id
+            ):
+                raise ValidationError(
+                    _(


Suggested change

_(

self.env._(

Similar to some other positions

Suggestion applied.

thienvh332 · 2025-01-22T04:31:46Z

account_move_name_sequence/models/account_journal.py

@@ -129,7 +131,7 @@ def _prepare_sequence_current_moves(self, refund=False):
            "Using default values.".format(self.id, refund and "refund" or "")
        )
        if not last_move:
-            _logger.warning("%s %s", msg_err, "No moves found")
+            _logger.debug("%s %s", msg_err, "No moves found")


I wonder why this change? I think it would be more reasonable for us to WARNING?

Change reverted.

Hehe, You can use assertLogs to intercept and check for warnings. It will help you pass the tests below 😉

Since the issue was in the post_init_hook, I added a context validation to mute the warning when desired.

Changelog: - Use Command syntax. - Replace `_()` by `self.env._()`. - Rename the method `_fetch_duplicate_supplier_reference` to `_fetch_duplicate_reference` to include both sale and purchase documents. - Add context validation to mute the warning when executing the `_prepare_sequence_current_moves` method without moves in the journals, allowing the warning to be muted when the method is executed in the `post_init_hook`. - Refactor tests to use `SetUpClass`, update the creation of payments with a related journal entry, and include the deletion of payments when deleting the moves. - Patch the `_validate_fields` and `_hash_moves` methods in tests to simulate the same behavior as if the journal entries are unlocked. This is done because, in the pipeline, the `account_journal_restrict_mode` module is installed, and it locks posted entries, preventing them from being set to draft or deleted afterward. - Add additional tests for the sequence prefix and chain to increase coverage. Co-authored-by: Bert Van Groenendael <[email protected]> Co-authored-by: oury.balde <[email protected]>

luisg123v · 2025-01-24T20:18:52Z

account_move_name_sequence/models/account_journal.py

@@ -30,7 +30,8 @@ class AccountJournal(models.Model):
        copy=False,
        check_company=True,
        domain="[('company_id', '=', company_id)]",
-        help="This sequence will be used to generate the journal entry number for refunds.",
+        help="This sequence will be used to generate "
+        "the journal entry number for refunds.",


Why this change?

Because of the pre-commit suggested change.

Is that done only after migrating?

luisg123v · 2025-01-24T23:44:37Z

account_move_name_sequence/tests/test_account_move_name_seq.py

+        cls.date = datetime.now()
+
+        cls.journals = cls.misc_journal | cls.purchase_journal | cls.sales_journal
+        with patch("odoo.models.BaseModel._validate_fields"):


Since it's not a trivial change, we could add a coment above explaining what's this for. This because patches are not functionally possible, so I think we should provide an explanation in such cases.

Same in similar cases were patches are applied.

luisg123v · 2025-01-24T23:52:01Z

account_move_name_sequence/tests/test_sequence_concurrency.py

-            # TODO: Delete payment and journal
+            moves = env["account.move"].with_context(force_delete=True).browse(move_ids)
+            payments = moves.payment_ids
+            moves_without_payments = moves - payments.mapped("move_id")


mapped not required

luisg123v · 2025-01-24T23:53:47Z

account_move_name_sequence/tests/test_sequence_concurrency.py

+                payments.unlink()
+            if moves_without_payments:
+                moves_without_payments.button_draft()
+                moves_without_payments.unlink()


Why not removing all moves instead of only the ones without payments?

Removing the payments already removes the entries related to them. Therefore, it is only necessary to remove the other moves that were not created from a payment.

luisg123v · 2025-01-24T23:54:22Z

account_move_name_sequence/tests/test_sequence_concurrency.py

            env.cr.commit()

    def _create_invoice_payment(
        self, deadlock_timeout, payment_first=False, ir_sequence_standard=False
    ):
-        odoo.registry(self.env.cr.dbname)
+        Registry(self.env.cr.dbname)


I think this does nothing.

luisg123v · 2025-01-24T23:56:46Z

account_move_name_sequence/tests/test_sequence_concurrency.py

@@ -344,6 +373,7 @@ def test_sequence_concurrency_95_pay2inv_inv2pay(self):
                args=(deadlock_timeout, False, True),
                name="Thread invoice payment",
            )
+            self.env.registry.enter_test_mode(self.env.registry.cursor())


I think this should be done in the setUpClass method, along with the addClassCleanup to exit it.

alexis-via and others added 30 commits January 20, 2025 18:39

Add module account_move_name_sequence

acb40b8

This module restores the good old behavior where journal entry numbers were generated from a sequence configured on the journal.

sequence is now required on journals

e82ee5b

Add post-install script to create a sequence for all existing journals Update README accordingly

[REF] account_move_name_sequence: Add number_next_actual and date ran…

0bdf263

…ge lines data based on current moves

[FIX] ir_sequence: Fix creating date_range_seq with range_month and r…

e42e249

…ange_day More info about: - odoo/odoo#91019 TODO: Revert this commit after it is merged

[REF] account_move_name_sequence: Discard journals already configured

971fae7

[FIX] account_move_name_sequence: Fix sequence domain to assign only …

641b45e

…if it is empty

[FIX] account_move_name_sequence: Fix required journal fields in view

9b2fde1

The required flag was wrong for sequence_id and refund_sequence_id So, it was not possible to store any change in journal for journal different to sale and purchase

[REF] account_move_name_sequence: Add maintainers to myself

6248604

[REF] account_move_name_sequence: Adding concurrency cases in README

343177f

[REF] account_move_name_sequence: Use Odoo native methods + Typos

9743cbb

[MIG] account_move_name_sequence: Migration to 15.0

066dbc7

[FIX] account_move_name_sequence: Exclude no_gap sequences from _is_e…

ef12239

…nd_of_seq_chain

[MIG] account_move_name_sequence: Migration to 16.0

000afd5

[FIX] account_move_name_sequence: return sequence names do not add a …

8ab3d67

…space between name and returns.

[FIX] account_move_name_sequence: issue OCA#1465 vals get refund_sequ…

8239476

…ence true if value not get in vals

[FIX] account_move_name_sequence: call flush before _fetch_duplicate_…

e767935

…supplier_reference method same issue OCA#1501 this fix not working for v16 OCA#1514

[REF] account_move_name_sequence: Remove concurrency outdated cases f…

a74e53f

…rom the readme

[FIX] account_move_name_sequence: Now you can unlink moves without ch…

6ba2d93

…eck sequence fix: odoo/odoo@6112f4f

Added translation using Weblate (Croatian)

536bfbb

[FIX] account_move_name_sequence: computed fields raising warning

e411ccb

Added translation using Weblate (French)

361f20f

Added translation using Weblate (Spanish)

0223e93

[FIX] account_move_name_sequence: do not create duplicated sequences

0e2c81c

Added translation using Weblate (Arabic)

a61ce76

[REF] account_move_name_sequence: rename hooks file

7b6b858

Rename hooks file and use post_init_hook method to create journal sequences after module installation.

OCA-git-bot and others added 11 commits January 20, 2025 18:39

[BOT] post-merge updates

b926abc

[REF] account_move_name_sequence: Add unittest to create concurrency …

c0edc1b

…invoices Add demo data with standard implementation sequences In order to test locks issues without changing data (then reverting)

[UPD] Update account_move_name_sequence.pot

3481403

[BOT] post-merge updates

b511874

[IMP] account_move_name_sequence: split too long context definition

db0079b

Split the context definition in sequence_id and refund_sequence_id fields into multiple lines to improve readability.

[IMP] account_move_name_sequence: apply guidelines to name view files

cb54e41

Update name of view files to follow guidelines.

[BOT] post-merge updates

dc7e2c2

[IMP] account_move_name_sequence: pre-commit auto fixes

6a4ad6a

CLaurelB force-pushed the 18.0-mig-account_move_name_sequence-CLaurelB branch 5 times, most recently from 88a822c to 27ada85 Compare January 21, 2025 09:09

CLaurelB force-pushed the 18.0-mig-account_move_name_sequence-CLaurelB branch 3 times, most recently from 9215922 to c088e59 Compare January 21, 2025 19:57

thienvh332 approved these changes Jan 22, 2025

View reviewed changes

CLaurelB force-pushed the 18.0-mig-account_move_name_sequence-CLaurelB branch from c088e59 to 5459aa7 Compare January 22, 2025 04:19

CLaurelB requested a review from thienvh332 January 22, 2025 04:22

thienvh332 reviewed Jan 22, 2025

View reviewed changes

CLaurelB force-pushed the 18.0-mig-account_move_name_sequence-CLaurelB branch from 5459aa7 to ba9800c Compare January 22, 2025 05:08

CLaurelB force-pushed the 18.0-mig-account_move_name_sequence-CLaurelB branch from ba9800c to eb9c714 Compare January 22, 2025 05:56

CLaurelB requested a review from thienvh332 January 22, 2025 06:00

thienvh332 approved these changes Jan 22, 2025

View reviewed changes

luisg123v suggested changes Jan 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] account_move_name_sequence: Migration to 18.0 #2016

[MIG] account_move_name_sequence: Migration to 18.0 #2016

CLaurelB commented Jan 20, 2025

CLaurelB commented Jan 21, 2025

thienvh332 left a comment

thienvh332 Jan 22, 2025

thienvh332 Jan 22, 2025

CLaurelB Jan 22, 2025

thienvh332 Jan 22, 2025

CLaurelB Jan 22, 2025

thienvh332 Jan 22, 2025

CLaurelB Jan 22, 2025 •

edited

Loading

luisg123v Jan 24, 2025

CLaurelB Jan 25, 2025

luisg123v Jan 25, 2025

luisg123v Jan 24, 2025

luisg123v Jan 24, 2025

luisg123v Jan 24, 2025

CLaurelB Jan 25, 2025

luisg123v Jan 24, 2025

luisg123v Jan 24, 2025

[MIG] account_move_name_sequence: Migration to 18.0 #2016

Are you sure you want to change the base?

[MIG] account_move_name_sequence: Migration to 18.0 #2016

Conversation

CLaurelB commented Jan 20, 2025

CLaurelB commented Jan 21, 2025

thienvh332 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLaurelB Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLaurelB Jan 22, 2025 •

edited

Loading