-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_readonly_security #1859
[17.0][MIG] product_readonly_security #1859
Conversation
TT50471 [UPD] Update product_readonly_security.pot [BOT] post-merge updates
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-14.0/product-attribute-14.0-product_readonly_security Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_readonly_security/
97d6538
to
eae3770
Compare
@victoralmau, @carlos-lopez-tecnativa Could you please review this migration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review OK.
class TestProductReadonlySecurity(common.TransactionCase): | ||
@classmethod | ||
def setUpClass(cls): | ||
super().setUpClass() | ||
cls.env = cls.env( | ||
context=dict( | ||
cls.env.context, | ||
mail_create_nolog=True, | ||
mail_create_nosubscribe=True, | ||
mail_notrack=True, | ||
no_reset_password=True, | ||
tracking_disable=True, | ||
test_product_readonly_security=True, | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class TestProductReadonlySecurity(common.TransactionCase): | |
@classmethod | |
def setUpClass(cls): | |
super().setUpClass() | |
cls.env = cls.env( | |
context=dict( | |
cls.env.context, | |
mail_create_nolog=True, | |
mail_create_nosubscribe=True, | |
mail_notrack=True, | |
no_reset_password=True, | |
tracking_disable=True, | |
test_product_readonly_security=True, | |
) | |
) | |
from odoo.addons.base.tests.common import BaseCommon | |
class TestProductReadonlySecurity(BaseCommon): | |
@classmethod | |
def setUpClass(cls): | |
super().setUpClass() | |
cls.env = cls.env(context=dict(cls.env.context, test_product_readonly_security=True)) |
eae3770
to
306c541
Compare
306c541
to
3fa6ec8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot migration product_readonly_security |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at d9b7ce3. Thanks a lot for contributing to OCA. ❤️ |
Standard migration to v17