Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_readonly_security #1859

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

ChristianSantamaria
Copy link

Standard migration to v17

@ChristianSantamaria ChristianSantamaria force-pushed the 17.0-mig-product_readonly_security branch from 97d6538 to eae3770 Compare January 24, 2025 07:48
@ChristianSantamaria
Copy link
Author

@victoralmau, @carlos-lopez-tecnativa Could you please review this migration?

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.

Comment on lines 11 to 19
class TestProductReadonlySecurity(common.TransactionCase):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env(
context=dict(
cls.env.context,
mail_create_nolog=True,
mail_create_nosubscribe=True,
mail_notrack=True,
no_reset_password=True,
tracking_disable=True,
test_product_readonly_security=True,
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TestProductReadonlySecurity(common.TransactionCase):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env(
context=dict(
cls.env.context,
mail_create_nolog=True,
mail_create_nosubscribe=True,
mail_notrack=True,
no_reset_password=True,
tracking_disable=True,
test_product_readonly_security=True,
)
)
from odoo.addons.base.tests.common import BaseCommon
class TestProductReadonlySecurity(BaseCommon):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env(context=dict(cls.env.context, test_product_readonly_security=True))

@ChristianSantamaria ChristianSantamaria force-pushed the 17.0-mig-product_readonly_security branch from eae3770 to 306c541 Compare January 24, 2025 08:35
@ChristianSantamaria ChristianSantamaria force-pushed the 17.0-mig-product_readonly_security branch from 306c541 to 3fa6ec8 Compare January 24, 2025 08:38
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.

Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot migration product_readonly_security
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1859-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 24, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 24, 2025
62 tasks
@OCA-git-bot OCA-git-bot merged commit eca5aa4 into OCA:17.0 Jan 24, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d9b7ce3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants