Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] server_environment_ir_config_parameter #121

Merged
merged 35 commits into from
Oct 20, 2022
Merged

[16.0] [MIG] server_environment_ir_config_parameter #121

merged 35 commits into from
Oct 20, 2022

Conversation

baimont
Copy link
Contributor

@baimont baimont commented Oct 4, 2022 •
edited
Loading

#120

depends on #122

@oca-clabot
Copy link

Hey @baimont, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@baimont baimont force-pushed the 16.0-mig-server_environment_ir_config_parameter-bai branch 2 times, most recently from 78db10e to e5539b9 Compare October 4, 2022 12:33
acsonefho
acsonefho suggested changes Oct 4, 2022
View reviewed changes
server_environment_ir_config_parameter/tests/config_param_test.xml
@@ -0,0 +1,6 @@
<odoo>
<record model="ir.config_parameter" id="some_record_id">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be something else, no? some_record_id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just for tests - the xml_id is not important. what matters is the key and value

@baimont baimont force-pushed the 16.0-mig-server_environment_ir_config_parameter-bai branch from e5539b9 to 513e47e Compare October 4, 2022 12:42
@sbidoul
Copy link
Member

sbidoul commented Oct 4, 2022

/ocabot migration server_environment_ir_config_parameter

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 4, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 4, 2022
Open
8 tasks
@florian-dacosta
Copy link

Hello @baimont
I think this PR is missing and should be applied : https://github.com/OCA/server-env/pull/92/files
It was merged in 14.0 after the migration of 15.0 and therefore is missing.

@baimont
Copy link
Contributor Author

baimont commented Oct 10, 2022

Hello @baimont I think this PR is missing and should be applied : https://github.com/OCA/server-env/pull/92/files It was merged in 14.0 after the migration of 15.0 and therefore is missing.

Hello @florian-dacosta, I cherry-picked the commit you refer to. Thanks for your review

lmignon
lmignon approved these changes Oct 19, 2022
View reviewed changes
Copy link

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @baimont 👍 (Code review)

Waiting for the merge of #122

@sebalix
Copy link
Contributor

sebalix commented Oct 19, 2022

Commit acca2a2 to remove and we are good.

sbidoul and others added 16 commits October 19, 2022 19:50
@sbidoul @baimont
server_environment_ir_config_parameter
b88a355
@sbidoul @baimont
server_environment_ir_config_parameter: work around double ormcache i…
51a2610 
…ssue
@sbidoul @baimont
server_environment_ir_config_parameter: handle empty values better
30a1319
@sbidoul @baimont
server_environment_ir_config_param: silently replace values by config…
7c02dfe 
… values

This is much more robust that raising an error, and let modules
load ir.config_parameter from xml data files, while still enforcing
values from the config files.
@sbidoul @baimont
server_environment_ir_config_parameter: update roadmap
15b6f00
@sbidoul @baimont
server_environment_ir_config_parameter: migrate to 10.0
baac491
@rousseldenis @baimont
server_environment_ir_config_parameter Avoid loading import
3521339 
Odoo loads modules that contain static directory, so it wanted to load server_environment_files but it does not exist
@oca-transbot @baimont
OCA Transbot updated translations from Transifex
4ee454f
@sbidoul @baimont
missing sudo in server_environment_ir_config_param
890f2df 
Without this sudo get_param would fail when the first user reading a parameter that has changed in the configuration file does not have write access to system parameters.
@adrienpeiffer @baimont
server_environment_ir_config_parameter: missing return.
55f9ef4
@oca-transbot @baimont
OCA Transbot updated translations from Transifex
38cb747
@oca-transbot @baimont
OCA Transbot updated translations from Transifex
38f9b0c
@oca-travis @baimont
Update server_environment_ir_config_parameter.pot
5232a45
@baimont
[MIG] server_environment_ir_config_parameter from 11 to 12
5d77a38
@TDu @baimont
[MIG] fix tests
6495d9f 
Manual forward port of 11.0 migration commit by Thierry Ducrest.
@OCA-git-bot @baimont
[UPD] README.rst
35c819d
oca-travis and others added 19 commits October 19, 2022 19:50
@oca-travis @baimont
[UPD] Update server_environment_ir_config_parameter.pot
3fd8769
@oca-transbot @baimont
Update translation files
abbad05 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-12.0/server-env-12.0-server_environment_ir_config_parameter
Translate-URL: https://translation.odoo-community.org/projects/server-env-12-0/server-env-12-0-server_environment_ir_config_parameter/
@OCA-git-bot @baimont
[ADD] icon.png
49bc524
@OCA-git-bot @baimont
[UPD] README.rst
059c333
@grindtildeath @baimont
[MIG] server_environment_ir_config_parameter: Migration to 13.0
783f41d
@grindtildeath @baimont
[IMP] server_environment_ir_config_parameter: black, isort
e33a691
@grindtildeath @baimont
server_environment_ircp: Fix tests using contextmanager
456832c 
Before, the values used in the tests were coming from server_environment_files_sample
that were made available using a symbolic link in .travis.yml.
Now, it's loaded dynamically at test execution.
@oca-travis @baimont
[UPD] Update server_environment_ir_config_parameter.pot
fd4784d
@OCA-git-bot @baimont
[UPD] README.rst
ad34359
@oca-transbot @baimont
Update translation files
febabd0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-env-13.0/server-env-13.0-server_environment_ir_config_parameter
Translate-URL: https://translation.odoo-community.org/projects/server-env-13-0/server-env-13-0-server_environment_ir_config_parameter/
@OCA-git-bot @baimont
pre-commit update
e3f4dfd
@sbejaoui @baimont
[14.0][MIG] - migration server_environment_ir_config_parameter
c05bc52
@oca-travis @baimont
[UPD] Update server_environment_ir_config_parameter.pot
4036c04
@OCA-git-bot @baimont
[UPD] README.rst
5da47a7
@JuMiSanAr @baimont
[MIG] Migration to version 15.0
cc7a451
@baimont
[UPD] Update server_environment_ir_config_parameter.pot
3a8b05e
@OCA-git-bot @baimont
[UPD] README.rst
818efd3
@baimont
[MIG] server_environment_ir_config_parameter: Migration to 16.0
786a812
@legalsylvain @baimont
[IMP] server_environmnet_ir_config_parameter: display in the config p…
ef1f8ac 
…arameter list and form views the new field is_environment, and make the key and values readonly if checked
@baimont baimont force-pushed the 16.0-mig-server_environment_ir_config_parameter-bai branch from a8b5715 to ef1f8ac Compare October 19, 2022 17:53
@baimont
Copy link
Contributor Author

baimont commented Oct 19, 2022

Commit acca2a2 to remove and we are good.

done

@sebalix
Copy link
Contributor

sebalix commented Oct 20, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-121-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 905bddc into OCA:16.0 Oct 20, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 73d72ca. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-mig-server_environment_ir_config_parameter-bai branch October 20, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acsonefho acsonefho acsonefho requested changes

@rven rven rven approved these changes

@sebalix sebalix sebalix approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
merged 🎉 migration
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.