-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] server_environment #122
[16.0] [MIG] server_environment #122
Conversation
(lp:c2c-addons/6.1 rev 11)
(lp:c2c-addons/6.1 rev 11.1.4)
(lp:c2c-addons/6.1 rev 28.1.1)
…t is the blessed target. (lp:c2c-addons/6.1 rev 40.2.1)
(lp:c2c-addons/6.1 rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target. (lp:c2c-addons/6.1 rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems lsb_release outputs to stderr as well as stdout. This message will be printed to console, not logged nor shown among server infomation. That way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
nice with static files
* [IMP] load server environment options from odoo rcfile This allows delivering the code with default configuration options for all environments in the server_environment_file module, but letting the administrator override some configuration entries in the regular odoo configuration file. * server_environment_file: update README
/ocabot migration server_environment |
server_environment/__manifest__.py
Outdated
|
||
{ | ||
"name": "server configuration environment files", | ||
"version": "16.0.1.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump module version to 16.0.1.0.0
"version": "16.0.1.1.1", | |
"version": "16.0.1.0.0", |
Please follow the guidelines https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0.
This change doesn't have to be done in the pre-commit stuff commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrancoMaxime can you address this comment please? The version change should belong to the migration commit indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry, I'm sick, I'll fix it tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, we are not in a hurry :)
Could you cherry-pick these fixes as well https://github.com/OCA/server-env/pull/126/commits ?
In the meantime, rest well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebalix I took the initiative to apply the requested changes to move forward.
In some cases, we want to use a tech_name, but we do not use server environment on all the records, so tech_name should not be required.
2b05b46
to
2482923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FrancoMaxime 👍 (code review)
@sebalix Can you update your review plz? Thank you! |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 38bfb14. Thanks a lot for contributing to OCA. ❤️ |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 258ea21. Thanks a lot for contributing to OCA. ❤️ |
#120