Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] server_environment #122

Merged
merged 93 commits into from
Oct 19, 2022

Conversation

FrancoMaxime
Copy link
Member

jgrandguillaume and others added 30 commits October 4, 2022 11:11
(lp:c2c-addons/6.1  rev 11)
(lp:c2c-addons/6.1  rev 28.1.1)
…t is the blessed target.

(lp:c2c-addons/6.1  rev 40.2.1)
(lp:c2c-addons/6.1  rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target.

(lp:c2c-addons/6.1  rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems
lsb_release outputs to stderr as well as stdout. This message will be
printed to console, not logged nor shown among server infomation. That
way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
* [IMP] load server environment options from odoo rcfile

This allows delivering the code with default configuration options for
all environments in the server_environment_file module, but letting
the administrator override some configuration entries in the regular
odoo configuration file.

* server_environment_file: update README
@sbidoul
Copy link
Member

sbidoul commented Oct 4, 2022

/ocabot migration server_environment

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 4, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 4, 2022
8 tasks
@FrancoMaxime FrancoMaxime changed the title 16.0 mig server environment mfr [16.0] [MIG] server_environment Oct 4, 2022

{
"name": "server configuration environment files",
"version": "16.0.1.1.1",
Copy link

@rven rven Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump module version to 16.0.1.0.0

Suggested change
"version": "16.0.1.1.1",
"version": "16.0.1.0.0",

Please follow the guidelines https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0.
This change doesn't have to be done in the pre-commit stuff commit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoMaxime can you address this comment please? The version change should belong to the migration commit indeed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry, I'm sick, I'll fix it tomorrow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, we are not in a hurry :)
Could you cherry-pick these fixes as well https://github.com/OCA/server-env/pull/126/commits ?
In the meantime, rest well!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebalix I took the initiative to apply the requested changes to move forward.

FrancoMaxime and others added 3 commits October 19, 2022 13:46
In some cases, we want to use a tech_name, but we do not use server
environment on all the records, so tech_name should not be required.
@lmignon lmignon force-pushed the 16.0-mig-server_environment-mfr branch from 2b05b46 to 2482923 Compare October 19, 2022 11:46
Copy link

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FrancoMaxime 👍 (code review)

@lmignon
Copy link

lmignon commented Oct 19, 2022

@sebalix Can you update your review plz? Thank you!

@sebalix
Copy link
Contributor

sebalix commented Oct 19, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-122-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1011a85 into OCA:16.0 Oct 19, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 38bfb14. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-mig-server_environment-mfr branch October 19, 2022 17:14
@lmignon
Copy link

lmignon commented Oct 21, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-122-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 258ea21. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.