Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] mail_activity_board: hide button if has no activities #1468

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[17.0][FIX] mail_activity_board: hide button if has no activities #1468

merged 1 commit into from
Nov 22, 2024

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 13, 2024

Fixes #1467

@astirpe astirpe force-pushed the 17_fix_mail_activity_board branch from 4bdfe29 to 48a3b12 Compare October 13, 2024 09:35
CasVissers-360ERP
CasVissers-360ERP approved these changes Oct 13, 2024
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. I think this should be merged with priority. The bug is all over.

@CasVissers-360ERP
Copy link

Video with the bug: https://app.screencastify.com/v3/watch/r21Jfcvl79jQZx1ulKjH

StefanRijnhart
StefanRijnhart approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart StefanRijnhart mentioned this pull request Oct 31, 2024
Merged
@StefanRijnhart StefanRijnhart added this to the 17.0 milestone Oct 31, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Nov 22, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1468-by-hbrunn-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e228d34 into OCA:17.0 Nov 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c0e9e49. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@astirpe @CasVissers-360ERP @OCA-git-bot @hbrunn @StefanRijnhart