[18.0][MIG] mail_debrand: Migration to 18.0 #1539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellbristow
force-pushed
the
18.0-mig-mail_debrand
branch
from
3e16cb9 to
faadecc
Compare
There's no commits preservation, as the module doesn't serve as is on v9.
without this fix, any regular notification (added as follower, thread notifications...) were not parsed at all and as a consequence also not debranded.
Currently translated at 20.0% (1 of 5 strings) Translation: social-14.0/social-14.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_debrand/nl/
…ll change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead.
Partially fixes OCA#713 TT31737
- FIX bug when split email message by `to_keep` parameter. When the html code is split, it is broken. As a result of this, when it use `fromstring`,
it try to fix this by closing tags.
Example about fixed functionality:
message:
`
<table>
<tr>
<td>
{to_keep}
</td>
</tr>
</table>
`
Split messsage inside `remove_href_odoo` function:
part[0]
`
<table>
<tr>
<td>
`
--------
part[1]
`
</td>
</tr>
</table>
`
-----------------
Result when join by `to_keep`
`
<table>
<tr>
<td>
{to_keep}
</td>
</tr>
</table>
`
update function calls to use new internal names, use qweb_view engine to be able to specify the template via xmlid
…of type 'NoneType' has no len()
Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/es/
…l templates such as auth_signup's invitation email.
…ing was when using mail.mail_notification_light as a wrapper
Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/fr/
Currently translated at 100.0% (3 of 3 strings) Translation: social-17.0/social-17.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_debrand/it/
ellbristow
force-pushed
the
18.0-mig-mail_debrand
branch
from
faadecc to
bdcfc86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate mail_debrand to 18.0
Code unchaged other than updating
_()toself.env._()Installs in dev build, all unit tests pass