Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windowLevelActionMenu) customization support for windowLevelActionMenu #4725

Merged

Conversation

Devu-trenser
Copy link
Contributor

Context

  • Integrated customization for windowLevelActionMenu .
  • This PR has been incorporated by FlyWheel.io

Changes & Results

  • Integrated customization support for windowLevelActionMenu component using customization service.

Testing

  • Add customized windowLevelActionMenu and use it through the customization service.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Ubuntu 24.0
  • Node version: 18.20.5
  • Browser: Chrome

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 5577118
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/679877daf68cdb00080976d7
😎 Deploy Preview https://deploy-preview-4725--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 5577118
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/679877da2b556900083c6e4e
😎 Deploy Preview https://deploy-preview-4725--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Jan 23, 2025

Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience

@Devu-trenser Devu-trenser force-pushed the feat/windowLevelActionMenu-customization branch from a8a151a to bad5d70 Compare January 27, 2025 05:32
@Devu-trenser
Copy link
Contributor Author

Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience

@sedghi I've rebased on top of the new customization service and aligned the implementation accordingly. Let me know if there's anything else you'd like me to adjust. Thanks!

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks see my comments

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks see my comments

@sedghi sedghi merged commit 5addf51 into OHIF:master Jan 28, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants