Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for initialImageIndex mismatch issue for loading SR after disabling prompts #4732

Conversation

ashik-trenser
Copy link
Contributor

@ashik-trenser ashik-trenser commented Jan 24, 2025

Context

Changes & Results

  • Added initial image options to the viewport options while setting the displaysets from trackedMeasurementsContext.tsx file in order to get the initailImageIndex to be loaded after loading an SR after disabling the prompts.
  • Added a null checking in WindowlevelActionMenu inorder to prevent the error displayd while loading the SR after disabling the prompts.

Testing

Initial image is correctly loaded now after disabling the prompt and loading the SR.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 18.19.0
  • Browser: Chrome 132.0.6834.110

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 000d45f
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6798c07b92416a0008b1c4de
😎 Deploy Preview https://deploy-preview-4732--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 000d45f
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6798c07bba6242000802c8ff
😎 Deploy Preview https://deploy-preview-4732--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashik-trenser
Copy link
Contributor Author

@sedghi
Could you please make these changes available for 3.9 after this gets approved? Thank you.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments thanks

@ashik-trenser ashik-trenser force-pushed the fix/initial-image-index-for-sr-loading-without-prompt branch from 147634e to 000d45f Compare January 28, 2025 11:33
@sedghi sedghi merged commit 8e3e208 into OHIF:master Jan 28, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants