Update sign in page error handling #978
Open
+22
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,47 +60,7 @@ | |||
| {% endwith %} | |||
| <form method="post" class="form"> | |||
| {{ form.csrf_token }} | |||
| {% if form.errors %} | |||
There was a problem hiding this comment.
Couldn't find how this was used
arroyoAle
requested changes
Feb 11, 2025
| <h2>Sign in</h2> | ||
| {% if failed_authentication or form.username.errors | length > 0 %} | ||
| {% set error = { "text": "Email address is required" } %} | ||
| {% set errorUN = { "text": "Email Address is required", "id": 'username_error' } %} |
There was a problem hiding this comment.
At first glance this variable confused me, maybe something like error_username?
| {% if failed_authentication or form.password.errors | length > 0 %} | ||
| {% set error = { "text": "Password is required" } %} | ||
| {% set errorPW = { "text": "Password is required", "id": 'password_error' } %} |
|
Yeah have checked and this is just the sign in page.
|
|
/deploy wilkia |
|
Deploying to dev cluster with following parameters:
|
anwilkie
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR updates the error handling on the sign in page. It was identified in the DAC report that the error summary displayed a misleading please try again message. This has been updated with links to the specific errors.
The error summary was also being displayed as an info summary which has been updated.
How to test?
Navigate to the sign in page and generate a sign in error. Check the resulting error summary and components meets the requirements on the DAC report.
Check all other sign in page functionality remains unchanged.
Jira
RAS-1364