Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql] Remove deprecated reconnect option for mysql >= 80034 #11843

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

elpaso
Copy link
Collaborator

@elpaso elpaso commented Feb 12, 2025

MYSQL_OPT_RECONNECT is deprecated since mysql 80034

Fixes #11842

MYSQL_OPT_RECONNECT is deprecated since mysql 80034

Fixes OSGeo#11842
@elpaso elpaso added the funded through GSP Work funded through the GDAL Sponsorship Program label Feb 12, 2025
@rouault
Copy link
Member

rouault commented Feb 12, 2025

MYSQL_OPT_RECONNECT is deprecated since mysql 80034

for my information, do we know why it is deprecated: does mysql automatically reconnect without being explictly told ?

@elpaso
Copy link
Collaborator Author

elpaso commented Feb 12, 2025

MYSQL_OPT_RECONNECT is deprecated since mysql 80034

for my information, do we know why it is deprecated: does mysql automatically reconnect without being explictly told ?

I did some research but I have only found some comments regarding the fact that the automatic reconnect didn't work reliably in all situations and didn't leave the connection in a clean state, it was off by default and AFAIK it has no replacements.

I also tried to write some reconnection logic base when mysql_ping() returns false but I couldn't make it work. I could dig deeper if you think this is important.

@rouault
Copy link
Member

rouault commented Feb 12, 2025

I could dig deeper if you think this is important.

no, definitely not worth it. Thanks for the explanation !

@rouault rouault merged commit 857b4c6 into OSGeo:master Feb 12, 2025
38 checks passed
@rouault rouault added this to the 3.11.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ogr2ogr: MySQL driver uses deprecated MYSQL_OPT_RECONNECT option
2 participants