Add 'gdal raster calc' #11850
Open
Add 'gdal raster calc' #11850
+1,277
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
force-pushed
the
gdal-raster-calc
branch
from
9d69380 to
e07f29e
Compare
rouault
reviewed
Feb 14, 2025
| * do not already have such a subscript. For example, "X" would be | ||
| * replaced with "X[3]" but "X[1]" would be left untouched. | ||
| */ | ||
| static std::string SetBandIndices(const std::string &origExpression, |
There was a problem hiding this comment.
My reading of the implementation is that if someone would use a variable "X" and "aX", and the intented substitution would be only for "X", then "aX" would also get substituted. No ?
There was a problem hiding this comment.
Line 49 should prevent this. But I'll look at whether I can make test_gdalalg_raster_calc_expression_rewriting less convoluted.
There was a problem hiding this comment.
Hopefully improved by ed4b07a
jratike80
reviewed
Feb 14, 2025
dbaston
force-pushed
the
gdal-raster-calc
branch
from
0763b4a to
ed4b07a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
gdal raster calctool that provides much of the functionality ofgdal_calc.py. Some differences withgdal_calc.py:muparserexpression engine--input X=file.tifrather than-X file.tif--allBandsflag, the expression can either refer to all bands of a raster (--calc "X + 3") or a single band of a raster (--calc "X[1] + 3")--extent unionand--extent intersectionarguments are not supported, at least for now. I think these may best be handled by separate calls togdal raster mosaic/stackandgdal raster calcbut could be persuaded otherwise without much difficultygdal_calc.pyare not supported (yet?)--input name=dsn[band(s)]Feedback wanted!
What are related issues/pull requests?
#10067
#11209
#11656