i.rectify: Fix copy into fixed size buffer issue in main.c of i.recti…

…fy module (#4299) * Copy into fix size buffer issue * removed variable Len * Update imagery/i.rectify/main.c Co-authored-by: Nicklas Larsson <[email protected]> --------- Co-authored-by: Shubham Vasudeo Desai <[email protected]> Co-authored-by: Shubham Vasudeo Desai <[email protected]> Co-authored-by: Nicklas Larsson <[email protected]>
OSGeo · Sep 16, 2024 · 95c123d · 95c123d
1 parent c840f3c
commit 95c123d
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/imagery/i.rectify/main.c b/imagery/i.rectify/main.c
@@ -26,6 +26,8 @@
 #include <string.h>
 #include "global.h"
 
+#include <grass/gis.h>
+
 int seg_mb_img;
 
 func interpolate;
@@ -151,8 +153,14 @@ int main(int argc, char *argv[])
     interpolate = menu[method].method;
 
     G_strip(grp->answer);
-    strcpy(group.name, grp->answer);
-    strcpy(extension, ext->answer);
+    if (G_strlcpy(group.name, grp->answer, sizeof(group.name)) >=
+        sizeof(group.name)) {
+        G_fatal_error(_("Group name <%s> is too long"), grp->answer);
+    }
+    if (G_strlcpy(extension, ext->answer, sizeof(extension)) >=
+        sizeof(extension)) {
+        G_fatal_error(_("Extension <%s> is too long"), ext->answer);
+    }
     order = atoi(val->answer);
 
     seg_mb = NULL;