-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/history: New button for setting current computational region based on executed commands #3421
wxGUI/history: New button for setting current computational region based on executed commands #3421
Conversation
70190f0
to
02d9e77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the button towards the top of the region box, otherwise it may be hidden...
There is a lot of text, but I am not sure how to improve it, @veroandreo any idea? |
I am wondering if the arrangement in the bottom panel is sufficiently flexible. I also plan enhance the panel by the error info text (now we have only "failed" written and there is no clue what happened). So maybe we could divide the bottom panel to notebook with tabs: General info, Error info, Region settings and place particular boxes into these tabs?.. |
Well, users need to click over a command to get the region info, so Region settings as it was seems enough to me. What about using also green checks when region setting on command matches the current and red cross when it doesn't? Then with a text box appearing when hovering inform what it means. The amount of text is reduced in that way and the button could say update current region to or simply update current region. |
I like the idea of "Update current region" rather than "Set to .." but I do not understand much of how you think a check should be arranged. Where exactly would you put it, Vero? At the top? I would probably place the check at the top to the left and the button on the right-top side. Do you mean it like this? |
I imagined it could go either left or right from the box title, i.e., [check|cross] Region settings or Region settings [check|cross]... Does that make sense? Though, just below the box title, with something like |
d425565
to
ea3b792
Compare
Waits for merging #3679 to use proper icons |
I implemented the variant with Region match [check|cross] and the button "Update current region" next to it. It is concise, fitting into one row. Thank @veroandreo for the suggestion with the icons, I think it looks really good. :-) I plan to use icons for Check and Cross from #3679 (now there is only the Check icon among current icons) |
…egion from command history
Co-authored-by: Anna Petrasova <[email protected]>
ea3b792
to
03857f7
Compare
03857f7
to
39a9e27
Compare
After using proper icons and minor repositioning.. |
This PR enhances the history command info panel by adding the option for setting the current computational region settings to the one active upon the history command execution.
The original command info has only information about the computational region settings:
The new proposal adds information on whether the current region is equal to the region from the history or not. In the case that the two settings are not equal, the new button "Set as current region" is added:
If settings are equal the panel shows just the info message: