Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add deduplication to make update-po #3735

Merged
merged 1 commit into from
May 29, 2024

Conversation

neteler
Copy link
Member

@neteler neteler commented May 24, 2024

Add gettext message deduplication to make update-po step.

Fixes #3465

Add gettext message deduplication to `make update-po` step.

Fixes OSGeo#3465
@neteler neteler added the translation Message translation related label May 24, 2024
@neteler neteler added this to the 8.4.0 milestone May 24, 2024
@neteler neteler requested a review from HuidaeCho May 24, 2024 16:39
@neteler neteler self-assigned this May 24, 2024
@echoix
Copy link
Member

echoix commented May 24, 2024

Does msguniq work on all supported platforms?

@neteler
Copy link
Member Author

neteler commented May 24, 2024

msguniq is part of the gettext tools like msgmerge, so yes.

Man pages:

@echoix
Copy link
Member

echoix commented May 24, 2024

Good then, so it should be at least as compatible as the current state

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the general concept of the PR, but I am not pronouncing myself of the makefile syntax as such, or the details.

Copy link
Member

@HuidaeCho HuidaeCho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it. I think it works.

@neteler neteler merged commit df949ca into OSGeo:main May 29, 2024
26 checks passed
@neteler neteler deleted the update_po_deduplicate branch May 31, 2024 09:48
neteler added a commit that referenced this pull request May 31, 2024
Add gettext message deduplication to `make update-po` step.

Fixes #3465
neteler added a commit that referenced this pull request May 31, 2024
Add gettext message deduplication to `make update-po` step.

Fixes #3465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Message translation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] grasswxpy_de.po: has a duplicate message definition
3 participants