manual: correct v.surf.rst example #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update broken example.
github-actions
bot
added
vector
ninsbl
previously approved these changes
May 30, 2024
|
Didn't quite work for me (windows OSGeo4W grass-dev 8.4-314-xxxxxxxx-1) past the first v.surf.rst call (that problems started): There's even a traceback :( The first call failing is because I forgot to select the mapset after downloading the north carolina location
Full console output: Details
|
petrasovaa
approved these changes
May 30, 2024
However, are this/these error/s really related to the new example (as it works for others) or warrant a new issue/PR? |
|
I think these two warnings shouldn't be emitted when using the example call: Not enough points, and what does overshoot mean here? |
AFAIU, it predicts a really high value compared to the min-max range |
petrasovaa
requested changes
Jun 2, 2024
Co-authored-by: Anna Petrasova <[email protected]>
|
GRASS GIS Console output: Details
Line 326 still doesn't have enough points and overshoots. v.db.univar fails because db.univar fails. It calls grass/scripts/db.univar/db.univar.py Lines 79 to 97 in f598510
This is grass-dev 8.4-316-242731e-1 242731e |
neteler
commented
Jun 2, 2024
|
What I don't understand: why to you have Sometimes a kind of "parameter name shift" happens when the compilation is messed up due to partial compilations. In this case only |
|
The input was me that retried once, since it says that it didn't work the call before (I saw the difference in another call, I just tried before) |
In #3739 (comment) I gave the hypothesis that maybe a make libsclean might be missing. |
|
It is indeed a problem in db.univar, but the cause I had is very different and specific to windows, where the logic was wrong. The logic checks if there is an executable called |
So we need a different implementation for grass/scripts/db.univar/db.univar.py Line 83 in f598510 --> reported in #3778 |
petrasovaa
approved these changes
Jun 3, 2024
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Update broken user example with more meaningful thresholds. Co-authored-by: Anna Petrasova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update broken example (
r.randomusage and more meaningful threshold).