-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.info: add JSON support #3755
v.info: add JSON support #3755
Conversation
You can go in the files tab of the PR, and choose multiple suggestions to add in the same commit. |
7ccf698
to
9ae3726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You started your new branch from your r.info one. One way to fix it is just to delete files.
Or follow instructions similar to #3763 (comment), I just walked through the same situation with another contributor a couple minutes ago |
c74840a
to
4a252c4
Compare
fbdd9a5
to
2b4d017
Compare
Use parson to add json output format support to the v.info module. The module has various flags to control the fields being output in case of plain format. The current prototype ignores the flags and always outputs all data for the JSON output.
Co-authored-by: Vaclav Petras <[email protected]>
132c4d3
to
159dbf6
Compare
Hi! I have updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Let's go with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kritibirda26 Looks good!
Use parson to have JSON as an output format support. The module has various flags to control the fields being output in case of plain shell format controlled by flags. All (-get) of these are enabled when using format=shell. format=plain now allows use of flags. This may need special handling in the future to resolve the edge cases in a better way.
Builds on #3744
Use parson to add json output format support to the v.info module. The module has various flags to control the fields being output in case of plain format. The current prototype ignores the flags and always outputs all data for the JSON output.