wxGUI: Use r.mask.status to get info about mask #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI
|
Depends on #4531. |
echoix
force-pushed
the
use-r_mask_status-in-gui
branch
from
197732c to
62afeed
Compare
This replaces low level checks of MASK raster in the current mapset with calls of r.mask.status. GConsole and SbMask require r.mask.status to output a potential name of the mask regerdless of mask being set or not, so this functionality still needs to be implemented first before moving this PR forward. History changes seem to be complete.
wenzeslaus
force-pushed
the
use-r_mask_status-in-gui
branch
from
62afeed to
7a965a5
Compare
…running tools based on direct user input.
|
@lindakarlovska Feel free to review or comment here. I might be able to incorporate changes even after this is merged. |
29 tasks
petrasovaa
requested changes
Jan 28, 2025
petrasovaa
approved these changes
Jan 29, 2025
|
That's a nice improvement. Just thinking about the sense of possible r3.mask.status module. I am wondering how often users use 3D mask... or maybe more general, how many people work with 3D rasters in GRASS, do you have any idea @wenzeslaus ? |
|
Handling 3D rasters better would make sense. It's a kind of chicken and egg problem - more tools would lead to more usage, and more usage would lead to more tools. I was quite happy when I used them, but wished for more tools (and added some). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces low level checks of MASK raster in the current mapset with calls of r.mask.status. At the same time, it prepares the code for arbitrary mask names from #2392.
GConsole and SbMask require r.mask.status to output a potential name of the mask regardless of mask being set or not, so this is using the
namefrom #4531 in r.mask.status which simply gives the name of the mask whether or not it is active.History now records the name of the mask both for 2D and 3D. This is not used in the GUI at this point.
The status bar does not say "MASK" in all caps anymore, but says "Mask" or "raster mask".