gui: Early exit from functions or loops #4916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flattens nested conditionals and moves error messages or returns near the top
Flattens nested conditionals and moves error messages near the top
petrasovaa
requested changes
Jan 25, 2025
Comment on lines
+1701
to
+1703
| (self.GCPcount >= 3 or self.gr_order != 1) | ||
| and (self.GCPcount >= 6 or self.gr_order != 2) | ||
| and (self.GCPcount >= 10 or self.gr_order != 3) |
There was a problem hiding this comment.
This may be correct, but it's completely unreadable. Maybe evaluate these separately before?
Comment on lines
+1725
to
+1727
| (self.GCPcount >= 3 or self.gr_order != 1) | ||
| and (self.GCPcount >= 6 or self.gr_order != 2) | ||
| and (self.GCPcount >= 10 or self.gr_order != 3) |
Comment on lines
+1065
to
+1067
| (self.GCPcount >= 3 or self.gr_order != 1) | ||
| and (self.GCPcount >= 6 or self.gr_order != 2) | ||
| and (self.GCPcount >= 10 or self.gr_order != 3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #4910, but for files in gui/.
I verified all the changes when committing them to make sure they are equivalent and that they kept the comments. The places I was unsure I reverted them, so these are the ones that make sense