Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Apply OSGeo4W patches for Postgres #4996

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Windows: Apply OSGeo4W patches for Postgres #4996

merged 4 commits into from
Jan 28, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Jan 27, 2025 •
edited
Loading

Solves #4990
(Hopefully)

I quickly applied the patch that changed downstream. I didn’t test it in CI yet, I’m just launching it here quickly.

It seems like Postgres is compiled with a different compiler now, so removing and copying a lib seems necessary.

I also launched echoix#351

@github-actions github-actions bot added the windows Microsoft Windows specific label Jan 27, 2025
@echoix echoix linked an issue Jan 27, 2025 that may be closed by this pull request
[Bug] OSGeo4w builds fail unable to locate PostgreSQL library #4990
Closed
@echoix echoix marked this pull request as draft January 27, 2025 18:30
@echoix
Copy link
Member Author

echoix commented Jan 27, 2025

Not enough :(

@echoix
Copy link
Member Author

echoix commented Jan 27, 2025 •
edited
Loading

Ok, I don't understand why the path I set isn't shown in the configure failure, I changed that line...
Edit: ah, we have two scripts, we need to mirror it in the other script too

@echoix echoix marked this pull request as ready for review January 27, 2025 18:56
@echoix echoix force-pushed the osgeo4w-postgre-patch branch from 8d7971b to c7b1427 Compare January 27, 2025 19:07
@echoix
Copy link
Member Author

echoix commented Jan 28, 2025

It seems enough to copy the lib like in package.sh (used in osgeo4w), the build passed the configure stage.

It is our highest priority PR for now, it is blocking all other work

@echoix echoix added the blocker Blocking a release label Jan 28, 2025
@echoix echoix requested a review from wenzeslaus January 28, 2025 00:35
wenzeslaus
wenzeslaus approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't understand the nuances of patching the files downstream and having two files here, this looks good to me. Clearly, the change is needed here, too, not only downstream.

@echoix echoix merged commit 54553df into OSGeo:main Jan 28, 2025
27 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Jan 28, 2025
@neteler neteler removed the blocker Blocking a release label Jan 29, 2025
@neteler
Copy link
Member

neteler commented Jan 29, 2025 •
edited
Loading

l'll try to backport this to G84, see #5005

neteler added a commit to neteler/grass that referenced this pull request Jan 29, 2025
@neteler
Windows: Apply OSGeo4W patches for Postgres (backport)
415af9a 
Backport of OSGeo#4996 to G84 branch
@neteler neteler mentioned this pull request Jan 29, 2025
Merged
neteler added a commit that referenced this pull request Jan 29, 2025
@neteler
Windows: Apply OSGeo4W patches for Postgres (backport) (#5005)
ec54064 
Backport of #4996 to G84 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

Assignees
No one assigned
Labels
windows Microsoft Windows specific
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

[Bug] OSGeo4w builds fail unable to locate PostgreSQL library
3 participants
@echoix @neteler @wenzeslaus