r.fillnulls: Modified tests for r.fillnulls module #5026
+91
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
petrasovaa
requested changes
Feb 5, 2025
| overwrite=True, | ||
| ) | ||
| self.assertModule(module) | ||
| self.assertRasterFitsUnivar(raster=self.mapComplete, reference=self.values) |
There was a problem hiding this comment.
Instead of just checking there are no null cells, please also include other stats like mean, min, max
| self.assertModule(module) | ||
| self.assertRasterMinMax(self.mapComplete, refmin=57, refmax=100) | ||
|
|
||
| self.runModule("r.mask", flags="r") |
There was a problem hiding this comment.
Move removing mask right after the computation, before the asserts. In this case it doesn't matter but computing the stats should not be done when mask is active.
There was a problem hiding this comment.
If i remove the mask before the asserts the test fails because i think it analyses all the cells instead of just the masked regions. Is there any other way to go around this?
There was a problem hiding this comment.
It shouldn't fail. That's the whole point, you want to test the mask was properly applied and for that you need to turn it off for the asserts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications: