Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.nviz.image: Fix Resource Leak issue #5079

Merged
merged 11 commits into from
Feb 26, 2025
Merged

Conversation

ShubhamDesai
Copy link
Contributor

@ShubhamDesai ShubhamDesai commented Feb 9, 2025

This pull request fixes issue identified by Coverity Scan (CID : 1207735, 1207736, 1207924, 1207925, 1208025, 1208026, 1208027, 1208028, 1208029, 1400466, 1501205, 1501280, 1501338)
Used G_free() to fix this issue.

@github-actions github-actions bot added C Related code is in C module misc labels Feb 9, 2025
@nilason nilason added this to the 8.5.0 milestone Feb 10, 2025
@nilason
Copy link
Contributor

nilason commented Feb 10, 2025

There are a number of similar issues in m.nviz.image, please filter with misc/m.nviz.image/*, to address them all (they all seem to be uncomplicated).

@ShubhamDesai
Copy link
Contributor Author

There are a number of similar issues in m.nviz.image, please filter with misc/m.nviz.image/*, to address them all (they all seem to be uncomplicated).

done all changes

@ShubhamDesai ShubhamDesai changed the title m.nviz.image: Fix Resource Leak issue in volume.c m.nviz.image: Fix Resource Leak issue Feb 10, 2025
@nilason
Copy link
Contributor

nilason commented Feb 10, 2025

All calls to G_fully_qualified_name() returns an allocated value which must be freed.

@ShubhamDesai
Copy link
Contributor Author

All calls to G_fully_qualified_name() returns an allocated value which must be freed.

done

ShubhamDesai and others added 3 commits February 10, 2025 17:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ShubhamDesai
Copy link
Contributor Author

All calls to G_fully_qualified_name() returns an allocated value which must be freed.

is there anything wrong in code? mac build failed.
I would fix the clang formatting issues sorry about the noise.

Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few suggestions.

Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion, otherwise good!

Co-authored-by: Nicklas Larsson <[email protected]>
@nilason nilason enabled auto-merge (squash) February 25, 2025 22:15
@nilason nilason merged commit 34b6764 into OSGeo:main Feb 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C misc module
Projects
Development

Successfully merging this pull request may close these issues.

2 participants