Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.emissivity: added test file for i.emissivity module #5127

Merged
merged 14 commits into from
Feb 27, 2025

Conversation

jayneel-shah18
Copy link
Contributor

This PR introduces a comprehensive test suite for the i.emissivity GRASS GIS module. The test suite is designed to validate core functionality, assess statistical correctness, and handle edge cases to ensure robust module behavior.

Key Updates in this PR:


  • Validate raster output generation and behavior under different NDVI conditions.
  • Ensure correct handling of masked regions.
  • Test behavior with different spatial resolutions.
  • Verify response to extreme NDVI values and partial null inputs.

Test Case Additions


Basic Functionality

  • NDVI Range Validity: Ensure correct emissivity values are generated for valid NDVI inputs (test_emissivity_ndvi_range).
  • Masked Regions: Validate handling of irregularly shaped masks (test_complex_mask).

Advanced Properties

  • Spatial Resolution Handling: Check that the module produces consistent results across different region resolutions (test_region_resolution).
  • Null Value Handling: Assess behavior when NDVI contains null values (test_partial_null_values).
  • Extreme NDVI Values: Test module response when NDVI is outside the valid range (test_extreme_ndvi_values).

Performance

  • The test suite execution times:
    • Windows: 2.315s
    • macOS: 1.353s
    • Ubuntu: 1.868s

Future Enhancements


  • Performance benchmarking for large-scale regions.
  • Stress testing with extreme parameter variations.

This test suite enhances the reliability of the i.emissivity module by covering a broad spectrum of cases. Looking forward to feedback and potential refinements!

@github-actions github-actions bot added Python Related code is in Python module imagery tests Related to Test Suite labels Feb 15, 2025
@echoix
Copy link
Member

echoix commented Feb 25, 2025

You don't need to update the branch as much, if there's not a particular reason for it. The last merge hadn't even completed yet

@echoix echoix merged commit 0ecd9fd into OSGeo:main Feb 27, 2025
28 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Feb 27, 2025
@jayneel-shah18 jayneel-shah18 deleted the i.emissivity_tests branch February 27, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imagery module Python Related code is in Python tests Related to Test Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants