Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.hull: Add the test cases #5135

Merged
merged 11 commits into from
Feb 26, 2025
Merged

v.hull: Add the test cases #5135

merged 11 commits into from
Feb 26, 2025

Conversation

codersmiti
Copy link
Contributor

This PR introduces test suite for the v.hull GRASS GIS module, covering a range of scenarios, including validating the module's functionality, geometric correctness, and edge-case handling for convex hull generation. The test cases cover a variety of scenarios, including collinear points, non-collinear points, duplicate points, concave shapes, and 3D inputs.

Key updates in this PR include:

  • Functionality: Validate convex hull creation for 2D and 3D point sets, ensuring correct output existence and dimensions.

  • Edge Cases: Test collinear points, duplicate points, and concave shapes to ensure robust handling of degenerate and non-standard inputs.

  • Geometric Correctness: Verify the number of vertices, polygon closure, and correct exclusion of interior concave points.

  • 3D Inputs: Validate the formation of a tetrahedron from 3D input points.

Test Case Additions:

  • Basic Functionality:

    • Verify the creation and existence of the convex hull output.

    • Test input handling for 2D and 3D point sets.

  • Edge Cases:

    • Collinear Points: Ensure the convex hull forms a degenerate boundary with exactly 3 vertices.

    • Duplicate Points: Test that duplicate points do not affect the hull structure.

    • Concave Shapes: Validate that the convex hull ignores interior concave points.

  • Geometric Correctness:

    • Non-Collinear Points: Verify the convex hull correctly encloses a non-collinear set of points.

    • 3D Inputs: Test the formation of a tetrahedron from 3D input points.

@github-actions github-actions bot added vector Related to vector data processing raster Related to raster data processing Python Related code is in Python HTML Related code is in HTML module docs tests Related to Test Suite labels Feb 18, 2025
@codersmiti codersmiti changed the title v.hull : Added the test cases for v.hull module v.hull: Added the test cases for v.hull module Feb 18, 2025
@wenzeslaus wenzeslaus changed the title v.hull: Added the test cases for v.hull module v.hull: Add the test cases Feb 25, 2025
@petrasovaa petrasovaa merged commit c855d99 into OSGeo:main Feb 26, 2025
28 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Feb 26, 2025
@codersmiti codersmiti deleted the feature branch March 2, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants