-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update mkdocs edit on github to work with addons #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
reviewed
Feb 20, 2025
This PR is dependent on #5177 |
wenzeslaus
reviewed
Feb 25, 2025
With #5152 and OSGeo/grass-addons#1330 merged, this should run nicely in CI and create an artifact. |
wenzeslaus
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The edit works with both core and addon tools in the artifact. The added code complexity seems reasonable given we need two different repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the material mkdocs edit and view on GitHub buttons to work with docs form grass-addons.
Address part of issue: #5158
To test you need to simulate what building the addons like PR #5152 .
Make sure grass is built with the new md files.
run
/grass-addons/utils/cronjobs_osgeo_lxd/compile_addons_git.sh
#PR cronjobs: Add Markdown and generalize addon build grass-addons#1330cp grass-addons/addons-build-dir/docs/md/source/* grass/dist.x86_64-pc-linux-gnu/docs/mkdocs/source/addon
cd
into the man directory and run the mkdocs server