config: Adjust gitignore for CMake #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilason
reviewed
Feb 22, 2025
nilason
reviewed
Feb 22, 2025
|
We should add a prohibiting check if attempt to build in source root dir. This is good in the meantime. |
nilason
approved these changes
Feb 22, 2025
CMake (the latest release at least) already displays a multiline warning saying what's happening and that it will be disallowed in the future, like in this first post: https://discourse.cmake.org/t/cmake-warning-no-source-or-binary-directory-provided/12883 |
HuidaeCho
approved these changes
Feb 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying out locally, I had 8k+ files that wanted to be commited. Adjust the .gitignore in consequence.
I excluded the build/ folder and allowed "Makefile" since we still have some, but if ever someone does a build without using a build directory, the makefiles of the repo will be modified in-place. This also means that if someone uses a different folder name for the build directory, everything but the makefiles will be ignored. I kept the "Makefile" commented out in the .gitignore to show that. Using
git clean -d -f -xcould help to delete what is not in source control.