Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use SQLite <3.49.0 on macOS #5196

Merged
merged 1 commit into from
Feb 23, 2025
Merged

CI: use SQLite <3.49.0 on macOS #5196

merged 1 commit into from
Feb 23, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Feb 23, 2025

Cherry pick of @nilason's commit on releasebranch_8_4

@nilason @echoix
CI: use SQLite <3.49.0 on macOS
cddd3de 
Co-authored-by: Nicklas Larsson <[email protected]>
@echoix echoix requested a review from nilason February 23, 2025 13:43
@github-actions github-actions bot added the macOS macOS specific label Feb 23, 2025
@echoix
Copy link
Member Author

echoix commented Feb 23, 2025 •
edited
Loading

We would probably need to do a change anyways sometime soon, see the justification and what is encouraged here: https://www.sqlite.org/quirks.html#dblquote

nilason
nilason approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make an issue of addressing this properly, so we won’t forget.

@echoix echoix mentioned this pull request Feb 23, 2025
Closed
@echoix
Copy link
Member Author

echoix commented Feb 23, 2025

Could you please make an issue of addressing this properly, so we won’t forget.

Done in #5197

@echoix echoix merged commit bde7171 into OSGeo:main Feb 23, 2025
23 checks passed
@echoix echoix deleted the macos-sqlite branch February 23, 2025 15:10
@github-actions github-actions bot added this to the 8.5.0 milestone Feb 23, 2025
@nilason
Copy link
Contributor

nilason commented Feb 23, 2025

Could you please make an issue of addressing this properly, so we won’t forget.

Done in #5197

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilason nilason nilason approved these changes

Assignees
No one assigned
Labels
macOS macOS specific
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@echoix @nilason