r.basins.fill: Fix Broken Tests and Preserve Test Dataset Integrity #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Bansal <[email protected]>
github-actions
bot
added
raster
Signed-off-by: Nishant Bansal <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
|
Well, looking more into it, this entire test is pretty much useless. So I would either rewrite it completely or drop it. |
Oh, let me rewrite this then. I'll update once it's done. |
Signed-off-by: Nishant Bansal <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
Hey @petrasovaa, I rewrote the tests. Can you take a look? |
petrasovaa
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Thank you, this is much better! I tried to run it and I suggest:
- reduce computational region (resolution or extent) , the test runs almost 20s on my computer, which is unnecessarily long. No need for g.region print flag here.
- it expects zeros, not nulls in stream raster (this tool was written long time ago when nulls were not even implemented). You can use r.null here.
Signed-off-by: Nishant Bansal <[email protected]>
petrasovaa
previously approved these changes
Mar 3, 2025
petrasovaa
reviewed
Mar 3, 2025
Signed-off-by: Nishant Bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR resolves issues in the r.basins.fill module tests as outlined in ticket #3822. It applies the patch provided in testrbf_fix_mapnames.diff to address broken tests.
Key Changes:
The patch from ticket 3822 has been applied to correct broken tests in r.basins.fill.
Previously, the tests would overwrite the "elevation" and "geology_30m" maps, corrupting the test dataset. This PR now creates copies of these maps before processing, ensuring the original test data remains intact.
With the fixes in place, the temporary workaround using
@unittest.skip("See #3822")is no longer necessary and can be removed.