Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added site_author, social card bgcolor, and improved nav controls mkdocs configuration #5230

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cwhite911
Copy link
Contributor

Added default site author to html meta tags, improved navigation controls, and set default social card background color to GRASS primary color.

Social Card Background Color

image

Site Author

Default meta tag for all pages is GRASS development Team

Improved Navigation

Added "Back to Top" button

image

…n controls, set default soical card backgound color to GRASS primary color.
palette:
primary: custom
# accent: custom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that comment. Do you mean something else?

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it just needs a clean up of comment and it can be merged.

Comment on lines -64 to -68
# - git-revision-date-localized:
# enable_creation_date: true
# - git-committers:
# repository: OSGeo/grass
# branch: main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this for now because we are adding during the build process. They also have the same issue that the edit on GitHub plugin had where the tool is expecting a different directory structure for the docs and a single repository. The committers part could be cool to add in the future, but I don't think it is a priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants