Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a test suite for the i.landsat.acca GRASS GIS module, covering a range of scenarios, including cloud mask creation, cloud shadow detection, and the effect of different input parameters on cloud identification. The test cases ensure correct functionality across scenarios like thermal correlation, binary output validation, and the impact of the b45ratio threshold.
Key updates in this PR include:
Functionality: Validate cloud mask creation using i.landsat.acca and ensure proper cloud detection.
Edge Cases: Test cloud shadow detection and the impact of the b45ratio parameter on cloud detection.
Cloud Mask Validations: Ensure the cloud mask is binary (with only two unique values) and accurately represents cloud and non-cloud pixels, while validating that cloud pixels have higher thermal values than non-cloud pixels.
Test Case Additions:
Basic Functionality:
Edge Cases:
Cloud Shadow Detection: Test cloud shadow detection by ensure that shadow pixels are
detected, and the output is valid.
b45ratio Parameter Effect: Test the impact of the b45ratio parameter on cloud detection by adjusting it. Ensure that a higher b45ratio threshold results in fewer detected cloud pixels, indicating a more conservative approach to cloud identification.
Cloud and Thermal Correlation Validation: