r.carve: adding the option to read width, depth values from vector map table columns

[tmszi]

Adding the option to read width, depth values from vector map table columns issue #686.

[hellik]

typo

[wenzeslaus]

I have merged current main into this which refreshes the code base in the PR overall. The PR had some indentation changes included, so the new indented code from main should actually make this PR cleaner. Anyway, no conflicts with the main branch now.

[tmszi]

I have merged current main into this which refreshes the code base in the PR overall. The PR had some indentation changes included, so the new indented code from main should actually make this PR cleaner. Anyway, no conflicts with the main branch now.

Thanks!

[nilason]

Merged this to main again.

[neteler]

There is a mac CI failure:

x86_64-apple-darwin13.4.0-clang -D_FORTIFY_SOURCE=2 -isystem /Users/runner/miniconda3/envs/grass-env/include  -I/Users/runner/miniconda3/envs/grass-env/include -O2 -pipe -arch x86_64 -DGL_SILENCE_DEPRECATION -Wall -Wextra -Werror -I/Users/runner/miniconda3/envs/grass-env/include -I/Users/runner/work/grass/grass/dist.x86_64-apple-darwin13.4.0/include -I/Users/runner/work/grass/grass/dist.x86_64-apple-darwin13.4.0/include    -DPACKAGE=\""grassmods"\"   -I/Users/runner/work/grass/grass/dist.x86_64-apple-darwin13.4.0/include -I/Users/runner/work/grass/grass/dist.x86_64-apple-darwin13.4.0/include -DRELDIR=\"raster/r.buffer\" -o OBJ.x86_64-apple-darwin13.4.0/process_row.o -c process_row.c
enforce_ds.c:176:27: error: comparison of integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare]
            for (c = 0; c < sql.ncats; c++) {
                        ~ ^ ~~~~~~~~~
enforce_ds.c:637:58: error: unused parameter 'table' [-Werror,-Wunused-parameter]
               double *parm, double *def_value, dbTable *table,
                                                         ^
2 errors generated.
make[4]: *** [OBJ.x86_64-apple-darwin13.4.0/enforce_ds.o] Error 1

[nilason]

Docs in general need to be corrected, for a start, if not urgent fix perhaps milestone bump to 8.4 perhaps preferable.

[nilason]

table not used

[nilason]

”comparison of integers of different signs: 'unsigned int' and 'int' `[-Werror,-Wsign-compare]” compiler warning

[nilason]

Docs before function, see doxygen style, eg.

grass/lib/display/raster.c

Line 30 in 001bf57

/*!

[neteler]

The CI gcc tests show this error:

make[4]: Entering directory '/home/runner/work/grass/grass/raster/r.carve'
test -d OBJ.x86_64-pc-linux-gnu || mkdir -p OBJ.x86_64-pc-linux-gnu
gcc  -std=gnu11 -fPIC -Wall -Wextra -Werror  -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include   -I/usr/include/gdal -I/usr/include -DPACKAGE=\""grassmods"\"   -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -DRELDIR=\"raster/r.carve\" -o OBJ.x86_64-pc-linux-gnu/enforce_ds.o -c enforce_ds.c
enforce_ds.c: In function ‘enforce_downstream’:
enforce_ds.c:176:27: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
  176 |             for (c = 0; c < sql.ncats; c++) {
      |                           ^
enforce_ds.c: In function ‘set_value’:
enforce_ds.c:637:58: error: unused parameter ‘table’ [-Werror=unused-parameter]
  637 |                double *parm, double *def_value, dbTable *table,
      |                                                 ~~~~~~~~~^~~~~
cc1: all warnings being treated as errors