Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/admin proposals answers import #131

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Stef-Rousset
Copy link
Contributor

@Stef-Rousset Stef-Rousset commented Feb 12, 2025

🎩 Description

When a private field has been added to proposals, and there is a proposal that does not have a private body, it was not possible to access the proposal's show. The problem was detected after importing answers to proposals.

📌 Related Issues

Testing

  1. As an admin, go to the BO
  2. In the settings, go to decidim_awesome
  3. In "Champs de propositions personnalisées", click on "Champs privés" and add a private_field with a condition on a specific process that already have proposals, only on proposals functionality
  4. In the application, add 2 or 3 proposals with a response to that private_field
  5. Go back to BO, to the list of the proposals of that specific process.
  6. Check that when you click on "Répondre à la proposition" for the proposals you have created with private_fields, you can access the proposal's show and you see the private_field
  7. Check that when you click on "Répondre à la proposition" for the existing proposals without private_field that you can also access the proposal's show and see that the private_field section is empty.

Testing after answer's import

  1. In the BO, on the proposal's list, click on "Importer" and then "Importer des réponses depuis un fichier".
  2. Add a CSV or Excel file, with proposal's ids that are not in state "Amendment evaluating", and add answers to them (cf screenshot)
  3. Import the answers
  4. Check the steps 6 and 7 above, and check that your answers are well imported.

Tasks

  • [ X] Add specs

Screenshot

Capture d’écran 2025-02-12 à 17 10 34

@Stef-Rousset Stef-Rousset marked this pull request as ready for review February 12, 2025 17:09
Copy link
Contributor

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough test file! LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants