Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Улучшение кнопки добавления аватарки #1241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

koke228666
Copy link
Contributor

До: до(кошмар) После: после(шедевр)

@veselcraft
Copy link
Member

@WerySkok @Lumaeris @maksalees @mrilyew мнение? я бы принял

@veselcraft
Copy link
Member

какой то странный diff правда

@mrilyew
Copy link
Contributor

mrilyew commented Mar 3, 2025

тебе не нравится эта кнопка так не смотри

@koke228666
Copy link
Contributor Author

сам

@malushik
Copy link
Contributor

malushik commented Mar 3, 2025

Шановні розробники OpenVK, а я звертаю увагу на рядки з hard localisation, яких по хорошому не має бути 😿

@koke228666 koke228666 force-pushed the betteruploadava branch 2 times, most recently from 3bc2a65 to 3a8cbe0 Compare March 7, 2025 19:44
@koke228666 koke228666 closed this Mar 7, 2025
@koke228666
Copy link
Contributor Author

ненавижу гит

@koke228666 koke228666 reopened this Mar 7, 2025
@koke228666
Copy link
Contributor Author

@veselcraft вооот так получше должно быть

Copy link
Member

@veselcraft veselcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

приведи code style в порядок!)

Comment on lines 132 to 140
<div class="avatar_controls">
<div {if !$hasAvatar}style="display:none"{/if} class="avatarDelete hoverable"></div>
<div class="avatar_variants">
<a {if $hasAvatar}style="display:none"{/if} class="_add_image hoverable upload_image" id="add_image">
<span>{_add_image}</span></a>
<a {if !$hasAvatar}style="display:none"{/if} class="_add_image hoverable set_image" id="add_image">
<span>{_upload_new_picture}</span></a>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишние табы

document.querySelector(".avatar_controls").style.display = "none"
document.querySelector(".add_image_text").style.display = "block"
document.querySelector(".avatar_controls .set_image").style.display = "none"
document.querySelector(".avatar_controls .avatarDelete").style.display = "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишний таб

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants