feat(profile info): add custom genders #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Не вижу смысла в этом нововведении. |
|
Я лишь выполнил Issue #312 |
Это конечно хорошо, но оригинальный вк даже не предлагает другой пол кроме муж/жен. |
|
@n1rwana Лишнее |
|
Ок. |
|
@n1rwana Сделай лучше музыку))))))) |
согл |
|
за голоса)) |
|
Идея имеет жизнь, но только если добавить "Небинарный" (без указания пола) |
|
Resolves #748 |
|
Если всё-таки собрались менять |
celestora
force-pushed
the
master
branch
3 times, most recently
from
a9d021b to
cbec4b5
Compare
openvk-org
force-pushed
the
master
branch
5 times, most recently
from
e198aff to
2db815d
Compare
openvk-org
force-pushed
the
master
branch
25 times, most recently
from
e198aff to
2db815d
Compare
ghost
mentioned this pull request
|
бра |
celestora
requested changes
Oct 31, 2024
| @@ -72,6 +72,10 @@ | |||
| "gender" = "Gender"; | |||
| "male" = "male"; | |||
| "female" = "female"; | |||
| "non-binary" = "non-binary"; | |||
| "other" = "other"; | |||
| "other_gender_placeholder" = "I refer to myself as..."; | |||
| @@ -52,7 +52,7 @@ function get(string $user_ids = "0", string $fields = "", int $offset = 0, int $ | |||
| $response[$i]->verified = intval($usr->isVerified()); | |||
| break; | |||
| case "sex": | |||
| $response[$i]->sex = $usr->isFemale() ? 1 : 2; | |||
There was a problem hiding this comment.
мб оставить для совместимости? isFemale поменять на ?bool и возвращать NULL, если не кун и не тян
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
mrilyew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #312