Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): change image/video path to relative path #16533

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Oct 18, 2024

Overview

closes RQA-3297.
change URL to relative path.

Test Plan and Hands on Testing

attach/detach a pipette and make sure that all images and videos appear.

Risk assessment

low.

@TamarZanzouri TamarZanzouri requested a review from a team as a code owner October 18, 2024 16:37
@TamarZanzouri TamarZanzouri requested review from mjhuff and sfoster1 and removed request for a team October 18, 2024 16:37
@TamarZanzouri TamarZanzouri marked this pull request as draft October 18, 2024 16:54
@TamarZanzouri TamarZanzouri marked this pull request as ready for review October 18, 2024 18:38
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that does make sense. Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants