Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): migrate useHomePipettes to local-resources #16544

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 21, 2024

Overview

The new local-resources directory is a logical place to house on-the-fly maintenance runs that execute a set command list before closing the maintenance run, such as useHomePipettes. This PR just closes a TODO comment.

Risk assessment

low - no functional changes

@mjhuff mjhuff requested a review from a team October 21, 2024 13:44
@mjhuff mjhuff requested a review from a team as a code owner October 21, 2024 13:44
@mjhuff mjhuff requested review from smb2268 and removed request for a team and smb2268 October 21, 2024 13:44
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesss more stuff to resources. however I regret to inform you that you have a typo in the filename useGripperDispalyName.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in this filename!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tank u

@mjhuff mjhuff force-pushed the app_refactor-local-resources branch from 7bc54d1 to 1295b78 Compare October 21, 2024 15:20
@mjhuff mjhuff requested a review from sfoster1 October 21, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants