Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(robot-server): Use last run command for /runs/:runId/currentState links #16557

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 21, 2024

Overview

In #16417, it was noted that links should include a reference to the last completed command as opposed to the "current" command in order to prevent torn state. This PR updates the link to do just that.

Test Plan and Hands on Testing

  • Ran some protocols, noted that the command was in fact the last command at the time of query.

Changelog

  • Updated the links property within the runs/runId/currentState response.

Review requests

c8dce60 - Updates the behavior for get_current_command for historical runs with the behavior that I think we want given the comment, but is this actually the case? CC: @SyntaxColoring

Risk assessment

low

@mjhuff mjhuff requested review from a team as code owners October 21, 2024 20:08
@mjhuff mjhuff force-pushed the robot-server_update-curren-state-links branch 3 times, most recently from 8f7f0b1 to 363018f Compare October 21, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant