Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][task 1] enable Ruff UP032 rule in python/paddle/base #57408

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Sep 15, 2023

PR types

Others

PR changes

Others

Description

#57367 task1

@Liyulingyue
Copy link
Contributor Author

@gouzil

@gouzil
Copy link
Member

gouzil commented Sep 16, 2023

这个也没修完, 注意版本为ruff 0.0.289

ruff check .
paddle/fluid/pir/dialect/op_generator/api_gen.py:171:21: UP032 [*] Use f-string instead of `format` call
paddle/fluid/pir/dialect/op_generator/op_gen.py:1021:25: UP032 [*] Use f-string instead of `format` call
python/paddle/base/__init__.py:154:13: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layer_helper_base.py:354:17: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layers/math_op_patch.py:317:21: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layers/math_op_patch.py:339:17: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layers/math_op_patch.py:580:28: UP032 [*] Use f-string instead of `format` call
python/paddle/base/reader.py:1632:17: UP032 [*] Use f-string instead of `format` call
python/paddle/base/reader.py:1646:17: UP032 [*] Use f-string instead of `format` call
test/dygraph_to_static/test_pylayer.py:35:17: UP032 [*] Use f-string instead of `format` call
test/legacy_test/op_test.py:1627:41: UP032 [*] Use f-string instead of `format` call

@SigureMo SigureMo changed the title [CodeStyle][task 1] enable Ruff UP0032 rule in python/paddle/base [CodeStyle][task 1] enable Ruff UP032 rule in python/paddle/base Sep 16, 2023
@Liyulingyue
Copy link
Contributor Author

@gouzil

@gouzil
Copy link
Member

gouzil commented Sep 17, 2023

LGTM,@SigureMo

SigureMo
SigureMo previously approved these changes Sep 17, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 18, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 18, 2023

需要解决冲突

@luotao1
Copy link
Contributor

luotao1 commented Sep 20, 2023

需要解决冲突

@luotao1 luotao1 merged commit 4377a44 into PaddlePaddle:develop Sep 22, 2023
@Liyulingyue Liyulingyue deleted the up32_1 branch September 23, 2023 16:09
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
…addlePaddle#57408)

* base up032

* update up032

* Apply suggestions from code review
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
…addlePaddle#57408)

* base up032

* update up032

* Apply suggestions from code review
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…addlePaddle#57408)

* base up032

* update up032

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants