-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][task 1] enable Ruff UP032 rule in python/paddle/base
#57408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
这个也没修完, 注意版本为 ruff check .
paddle/fluid/pir/dialect/op_generator/api_gen.py:171:21: UP032 [*] Use f-string instead of `format` call
paddle/fluid/pir/dialect/op_generator/op_gen.py:1021:25: UP032 [*] Use f-string instead of `format` call
python/paddle/base/__init__.py:154:13: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layer_helper_base.py:354:17: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layers/math_op_patch.py:317:21: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layers/math_op_patch.py:339:17: UP032 [*] Use f-string instead of `format` call
python/paddle/base/layers/math_op_patch.py:580:28: UP032 [*] Use f-string instead of `format` call
python/paddle/base/reader.py:1632:17: UP032 [*] Use f-string instead of `format` call
python/paddle/base/reader.py:1646:17: UP032 [*] Use f-string instead of `format` call
test/dygraph_to_static/test_pylayer.py:35:17: UP032 [*] Use f-string instead of `format` call
test/legacy_test/op_test.py:1627:41: UP032 [*] Use f-string instead of `format` call |
SigureMo
changed the title
[CodeStyle][task 1] enable Ruff UP0032 rule in python/paddle/base
[CodeStyle][task 1] enable Ruff UP032 rule in Sep 16, 2023
python/paddle/base
LGTM,@SigureMo |
SigureMo
previously approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow 🐾
需要解决冲突 |
需要解决冲突 |
Liyulingyue
commented
Sep 20, 2023
SigureMo
approved these changes
Sep 22, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
…addlePaddle#57408) * base up032 * update up032 * Apply suggestions from code review
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
…addlePaddle#57408) * base up032 * update up032 * Apply suggestions from code review
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…addlePaddle#57408) * base up032 * update up032 * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#57367 task1