Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdoctest][task 376~381] reformat example code with google style #58173

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

ooooo-create
Copy link
Contributor

PR types

Others

PR changes

Others

Description

好像是添加 skip reson的任务,但是我把有些skip给删除了😂

修改如下文件的示例代码,使其通过 xdoctest 检查:
python/paddle/distribution/bernoulli.py
python/paddle/distribution/categorical.py
python/paddle/distribution/gumbel.py
python/paddle/hapi/dynamic_flops.py
python/paddle/hapi/model.py
python/paddle/hapi/model_summary.py

link #55629

@sunzhongkai588 @SigureMo @megemini

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 17, 2023
Comment on lines 200 to 201
>>> params_info = paddle.summary(lenet_dict_input, input=input_data)
>>> # doctest: +SKIP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里上面那行为啥直接删了呢?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

误删啦

@SigureMo SigureMo changed the title [xdoctest][task cleanup 376~381] reformat example code with google style [xdoctest][task 376~381] reformat example code with google style Oct 17, 2023
@SigureMo
Copy link
Member

好像是添加 skip reson的任务,但是我把有些skip给删除了😂

这个没关系,只要保证所有 skip 有 reason 即可,如果能删除 skip 且能通过的话,当然是最好的

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 18, 2023
@luotao1 luotao1 merged commit 9690055 into PaddlePaddle:develop Oct 18, 2023
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
@ooooo-create ooooo-create deleted the xdoctest365_370 branch October 25, 2023 09:38
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants