This repository has been archived by the owner on Dec 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Added PanOS 11 syslog standard fields; repaired broken field extracts & name collisions #294
Open
jwiley80
wants to merge
13
commits into
PaloAltoNetworks:develop
Choose a base branch
from
jwiley80:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#Field Aliases to match corrected Transforms extracts from https://docs.paloaltonetworks.com/pan-os/9-1/pan-os-admin/monitoring/use-syslog-for-monitoring/syslog-field-descriptions/user-id-log-fields
pan:system corrected dvc coalesce, added description extracts
…onfig data Removed "devicegroup_level3" and "devicegroup_level4" fields, which do not exist in the config data, and cause all later fields to parse incorrectly. Added PanOS 11 updated fields at end
extract_threat, extract_traffic, extract_globalprotect, and extract_hipmatch all contain the fields "host_id" and "host_serial" - this is extremely useful for asset correlation, and needs to be consistently named for analysis. In extract_globalprotect, the old version uses 'serial_number' for this field, which collides with field 3, which is the 'dvc_serial', not the serial of the src/user asset being described in the log
"high_res_timestamp"
hipmatch fieldalias & eval updates for CIM consistency
field aliases and evals added for CIM compatibility
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
Thanks for the PR! Seeing a lot of good changes here. With the breaking changes we'd have to do a major release with comprehensive release note so give us some time to go through everything and plan. @jwiley80 Can you remove any lines you commented out and do another commit/push? We'll see the lines are removed in the diff during review but having them still exist commented makes the diff harder to parse. Thanks again! |
paulmnguyen
force-pushed
the
develop
branch
2 times, most recently
from
May 17, 2023 20:58
de4dfdc
to
d7bd687
Compare
Any progress on this? I'm not sure if you're waiting on something from me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added PanOS 11 syslog standard fields; repaired broken field extracts & name collisions
How Has This Been Tested?
Tested in Splunk against large-scale existing pan:* data flows
Types of changes
Breaking change 1: In default/transforms.conf, [extract_userid] previously omitted the "src_user" field early in the message, causing all fields following it to parse incorrectly. This change includes the "src_user" field correctly, and causes all fields after it to parse correctly. The may cause breakage for some users, dashboards, or other use cases dependent the currently incorrect field assignments.
Breaking change 2: In default/transforms.conf, [extract_config] previously included the "devicegroup_level3" and "devicegroup_level4" fields that do not exist in the log data. All fields following these extracts have been parsing incorrectly. This change correctly excludes the "devicegroup_level3" and "devicegroup_level4" fields to match the data correctly, and causes all fields after that point to parse correctly. The may cause breakage for some users, dashboards, or other use cases dependent the currently incorrect field assignments.
Bug fixes:
In props.conf
In transforms.conf
Note: