Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more options for configuring ping passthrough. #1290

Open
wants to merge 16 commits into
base: dev/3.0.0
Choose a base branch
from

Conversation

TheMiningTeamYT
Copy link

When using Velocity, I have been frustrated by the lack of fine control over ping passthrough, specifically the lack of support for passing through favicons without passing through the whole ping request. I've also seen people on line asking how to pass through favicons, so I decided to add the ability to control which aspects of server list ping requests are passed through from the back end server, and which aspects aren't, through 5 new boolean configuration options in the config file.
Please don't judge my code too harshly, this is my first time writing Java, but it does compile and Checkstyle is okay with it.

Copy link
Contributor

@powercasgamer powercasgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either respect the original option or handle migration

@TheMiningTeamYT
Copy link
Author

TheMiningTeamYT commented Apr 16, 2024

Those changes are fine.
And it occurs to me that it probably would have been a good idea to give the commits more descriptive names...
too late now!

@TheMiningTeamYT
Copy link
Author

TheMiningTeamYT commented Dec 31, 2024

This should either respect the original option or handle migration

It took me months to understand what you were trying to say here; what you wanted me to do, and still longer for me to actually do it. For some reason, I only focused on the minor changes you had requested, and not your actual comment. But today, I sat down and implemented what you actually wanted. My branch now supports falling back to the old ping passthrough system if the new one isn't in use. I've tested the code on my server and the fallback works.
Please consider merging this as soon as possible. I can no longer synchronize my fork due to a minor conflict, and because I have been running a build of this fork since I opened this pull request, this means I can no longer update my personal Minecraft server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants