Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate buildSrc plugins to build-logic #986

Closed

Conversation

alexstaeding
Copy link
Contributor

As mentioned in #983, this PR migrates all buildSrc plugins to a build-logic project.

Everything should be functionally identical to the way it worked previously with the following exceptions:

  • The application of the publish plugin is done individually in the api and native projects. Previously, the following if-condition in the velocity publish plugin

    would lead to the api and native project to being published. I'm not sure if publishing the native project is intended, but that can be fixed easily.

  • I have centralized the repository declaration in settings.gradle.kts and enabled repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)

settings.gradle.kts Outdated Show resolved Hide resolved
build-logic/src/main/kotlin/velocity-publish.gradle.kts Outdated Show resolved Hide resolved
@alexstaeding
Copy link
Contributor Author

alexstaeding commented Jun 21, 2023

Applied suggested fixes for typos and fixed conflicts with base (dev/3.0.0)

@astei
Copy link
Contributor

astei commented Oct 27, 2023

Publishing the native is intentional, it was done for Krypton

@astei
Copy link
Contributor

astei commented Oct 27, 2023

Manually rebased and merged with 24ed83d - thanks for this

@astei astei closed this Oct 27, 2023
@alexstaeding alexstaeding deleted the refactor/build-logic branch October 27, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants