-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate buildSrc plugins to build-logic #986
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstaeding
force-pushed
the
refactor/build-logic
branch
from
March 26, 2023 22:14
c99fbf2
to
e621926
Compare
kashike
reviewed
Mar 26, 2023
Co-authored-by: Riley Park <[email protected]>
powercasgamer
suggested changes
Jun 16, 2023
Applied suggested fixes for typos and fixed conflicts with base (dev/3.0.0) |
powercasgamer
approved these changes
Jun 21, 2023
4drian3d
approved these changes
Jul 19, 2023
powercasgamer
approved these changes
Jul 19, 2023
Publishing the native is intentional, it was done for Krypton |
Manually rebased and merged with 24ed83d - thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #983, this PR migrates all
buildSrc
plugins to abuild-logic
project.Everything should be functionally identical to the way it worked previously with the following exceptions:
The application of the publish plugin is done individually in the api and native projects. Previously, the following if-condition in the velocity publish plugin
Velocity/buildSrc/src/main/kotlin/com/velocitypowered/script/VelocityPublishPlugin.kt
Line 36 in 36cc2bd
I have centralized the repository declaration in
settings.gradle.kts
and enabledrepositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)