Score and return only documents provided #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnGiorgi
reviewed
Dec 14, 2021
|
Looks good, I would maybe update the README and/or this docstring so this new parameter is documented somewhere. |
OK will do |
JohnGiorgi
reviewed
Dec 14, 2021
JohnGiorgi
reviewed
Dec 14, 2021
|
Suggested changes for two nitpicks but otherwise LGTM. |
Co-authored-by: John Giorgi <[email protected]>
Co-authored-by: John Giorgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a client parameter
use_docs(default =False) which instructs the service to return only uids provided in thedocuments. When True, this renderstop_kdispensable.Refs #61