main inline with next #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add extra events (#397) * chore: save logging to file * chore: hide fields feature flags * feat: right click context * fix: hide scroll * fix: create first issue tbn * fix: portal nav fix * fix: portal layout ui * chore: code cleanuo * chore: favicon
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const url = webhook.url; | ||
|
|
||
| if (url.includes("discord.com")) { |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 months ago
To fix the problem, we need to parse the URL and check its host against a whitelist of allowed hosts. This ensures that the URL is indeed pointing to a legitimate Discord domain and not a malicious one. We will use the url module from Node.js to parse the URL and then check the host.
- Import the
urlmodule. - Parse the URL to extract the host.
- Check the host against a whitelist of allowed hosts.
Suggested changeset
1
apps/api/src/lib/notifications/webhook.ts
| @@ -1,2 +1,3 @@ | ||
| import axios from "axios"; | ||
| import { URL } from "url"; | ||
|
|
||
| @@ -19,4 +20,6 @@ | ||
| const url = webhook.url; | ||
| const parsedUrl = new URL(url); | ||
| const allowedHosts = ["discord.com", "www.discord.com"]; | ||
|
|
||
| if (url.includes("discord.com")) { | ||
| if (allowedHosts.includes(parsedUrl.host)) { | ||
| const discordMessage = { |
Copilot is powered by AI and may make mistakes. Always verify output.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.