protect against broken custom field declarations

Piotrekol · Apr 15, 2023 · a4fb0ae · a4fb0ae
1 parent ed92f2d
commit a4fb0ae
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/CollectionManagerDll/Modules/FileIO/FileCollections/OsdbCollectionHandler.cs b/CollectionManagerDll/Modules/FileIO/FileCollections/OsdbCollectionHandler.cs
@@ -256,7 +256,15 @@ public IEnumerable<Collection> ReadOsdb(string fullFileDir, MapCacher mapCacher)
                                 Type = (CustomFieldType)_binReader.ReadByte(),
                                 DisplayText = _binReader.ReadString(),
                             };
-                            customFieldDefinitions.Add(key, def);
+                            try
+                            {
+                                customFieldDefinitions.Add(key, def);
+                            }
+                            catch (ArgumentException)
+                            {
+                                // custom field key is already used
+                                throw new CorruptedFileException($"Collection declared multiple custom fields with the same key");
+                            }
                         }
                     }