fix: session replay and auto capture works with 'with' method #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Jan 27, 2025
Comment on lines
75
to
80
| // its not guaranteed that the posthog instance is set | ||
| if (postHog != null) { | ||
| events.capture(postHog) | ||
| } else { | ||
| // use static instance | ||
| events.capture() |
There was a problem hiding this comment.
important part is here
marandaneto
commented
Jan 27, 2025
| @@ -64,7 +64,7 @@ public final class com/posthog/android/replay/PostHogReplayIntegration : com/pos | |||
| public static final field ANDROID_COMPOSE_VIEW_CLASS_NAME Ljava/lang/String; | |||
| public static final field PH_NO_CAPTURE_LABEL Ljava/lang/String; | |||
| public fun <init> (Landroid/content/Context;Lcom/posthog/android/PostHogAndroidConfig;Lcom/posthog/android/internal/MainHandler;)V | |||
| public fun install ()V | |||
| public fun install (Lcom/posthog/PostHogInterface;)V | |||
There was a problem hiding this comment.
technically a breaking change but we don't document this integration API anywhere so its ok (we only use intergrations internally)
marandaneto
changed the title
marandaneto
commented
Jan 28, 2025
Comment on lines
+45
to
+47
| if (props.isNotEmpty()) { | ||
| postHog?.capture("Deep Link Opened", properties = props) | ||
| } |
There was a problem hiding this comment.
fly by fix, no event should be captured if we don't know where it comes from
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #216
💚 How did you test it?
📝 Checklist