feat: add missing os to icon mapping (#29179)

PostHog · Feb 25, 2025 · 739c08e · 739c08e
1 parent 3506ea1
commit 739c08e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/frontend/src/lib/components/PropertyIcon.tsx b/frontend/src/lib/components/PropertyIcon.tsx
@@ -34,6 +34,14 @@ const osIcons = {
     ['android']: <IconAndroidOS />,
     ['ios']: <IconAppleIOS />,
     ['other']: <IconGearFilled />,
+    ['chrome os']: <IconChrome />,
+    ['windows mobile']: <IconWindows />,
+    ['windows phone']: <IconWindows />,
+    ['xbox']: <IconWindows />,
+    ['playstation']: <IconHeadset />,
+    ['nintendo']: <IconHeadset />,
+    ['blackberry']: <IconBlackberry />,
+    ['watchos']: <IconMacOS />,
 }
 
 export const PROPERTIES_ICON_MAP = {

diff --git a/frontend/src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx b/frontend/src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx
@@ -283,6 +283,16 @@ const BreakdownValueCell: QueryContextColumnComponent = (props) => {
                 )
             }
             break
+        case WebStatsBreakdown.OS:
+            if (typeof value === 'string') {
+                return (
+                    <div className="flex items-center gap-2">
+                        <PropertyIcon property="$os" value={value} />
+                        <span>{value}</span>
+                    </div>
+                )
+            }
+            break
     }
 
     if (typeof value === 'string') {