fix: patch dayjs to fix the utc timezone bug #23527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +5.2 kB (+0.49%) Total Size: 1.07 MB
|
Twixes
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
I think I actually ran into this problem a long while ago, which is why dayjsUtcToTimezone() has an extra check against UTC/GMT.
Not great that the project is abandoned, but this makes sense as a stopgap
thmsobrmlr
pushed a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Applies a patch with changes from iamkun/dayjs#2118. DayJS incorrectly handles UTC timezone in some cases creating dates for
startOf('month')in the past: 2024-07-08 results in 2024-06-30 23:00. Next calls shift the date even more to the past resulting in the bug from #23472.Changes
DayJS seems to be (temporarily?) abandoned. The PR adds a package patch to fix offsets.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manual testing