fix(livestream): Enable custom livestream host (#26106) #27667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yidir <[email protected]>
|
@pauldambra @benjackwhite Can you guys look into this? I made this change small to make it easy to merge. Thanks |
benjackwhite
requested changes
Jan 20, 2025
benjackwhite
requested changes
Jan 23, 2025
Signed-off-by: Yidir <[email protected]>
|
@Yiidiir I'm curious about what is the value of the env |
It should be set to whatever host is serving the livestream image and should be accessible from the client. Note that you'll have to use my branch for this to work since Mister @fuziontech didn't merge this yet |
|
I'm just gonna approve and merge this as it seems fine to me |
|
Sorry for the hold up @Yiidiir 🙌 |
benjackwhite
added a commit
that referenced
this pull request
Feb 14, 2025
|
What happened @benjackwhite 😂 |
|
Caused a bunch of issues so had to revert.Will fix it here |
HamedMP
pushed a commit
that referenced
this pull request
Feb 19, 2025
Signed-off-by: Yidir <[email protected]>
HamedMP
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Yidir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is for self-hosted instances, live event features are broken when not running on localhost because of a hard-coded value.
I can also follow up with an updated
docker-compose.hobby.ymlbut I feel the ability to set live events host is more important.Closes #26106
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Works for self-hosted / No impact for cloud
How did you test this code?
LIVESTREAM_HOSTvalue to URI of host serving livestream service